On Windows there isn't /dev/null device. Instead of this, we should use NUL device. Windows hasn't grep.exe by default. To make sunspider script work, you should install grep.exe eg from UnxUtils. I don't find any reason why grep is necessary in sunspider script. If it is really unnecessary, we should remove it, and the script will work on Windows too without installing grep.exe .
"grep -v break" added by Maciej, accordingly I added you to cc. Could you tell me why it is necessary? I don't find any "break" in jsc output. http://trac.webkit.org/changeset/26915
Created attachment 39849 [details] proposed patch
Created attachment 39850 [details] proposed patch sorry, I forgot adding bug to the ChangeLog
Created attachment 39852 [details] proposed patch Here is the new proposed patch, because grep should be necessary for sunspider-compare-result script. I'll try to find the function of this grep, and if I am convinced it is really unnecessary, I'll submit new patch to remove it.
Comment on attachment 39852 [details] proposed patch r=me
attachment 39852 [details] landed in: http://trac.webkit.org/changeset/48584
Comment on attachment 39852 [details] proposed patch Csaba isn't a committer, so I assume he (she?) wanted this automatted commit. You can opt in/out of auto-commit in the future using "commit-queue?" or "commit-queue-"
Comment on attachment 39852 [details] proposed patch Rejecting patch 39852 from commit-queue. Patch https://bugs.webkit.org/attachment.cgi?id=39852 from bug 29544 failed to download and apply.
(In reply to comment #7) > (From update of attachment 39852 [details]) > Csaba isn't a committer, so I assume he (she?) wanted this automatted commit. > You can opt in/out of auto-commit in the future using "commit-queue?" or > "commit-queue-" I asked Zoltan to commit this patch, he is our committer, and he done it. Should we have removed r+ flag after landing? I would like to leave open this bug, because it might need one more patch.
Created attachment 40224 [details] proposed patch I've found a nicer and platorm independent solution for null device problem.
Comment on attachment 40224 [details] proposed patch > diff --git a/SunSpider/ChangeLog b/SunSpider/ChangeLog > index e121eeb..8aa63bf 100644 > --- a/SunSpider/ChangeLog > +++ b/SunSpider/ChangeLog > @@ -1,3 +1,12 @@ > +2009-09-28 Csaba Osztrogonac <oszi@inf.u-szeged.hu> > + > + Reviewed by NOBODY (OOPS!). > + > + Platform specific null device replaced with a platform independent. > + https://bugs.webkit.org/show_bug.cgi?id=29544 > + > + * sunspider: Using File::Spec->devnull() instead of /dev/null and NUL. > + > 2009-09-21 Csaba Osztrogonac <oszi@inf.u-szeged.hu> > > Reviewed by Maciej Stachowiak. > diff --git a/SunSpider/sunspider b/SunSpider/sunspider > index 7825a63..20614b1 100755 > --- a/SunSpider/sunspider > +++ b/SunSpider/sunspider > @@ -160,8 +160,7 @@ sub writePrefixFile() > sub runTestsOnce($) > { > my ($useShark) = @_; > - my $nullDevice = ($^O eq "MSWin32") ? "NUL" : "/dev/null"; > - my $shellArgs = $jsShellArgs . " -f $prefixFile -f resources/sunspider-standalone-driver.js 2> " . $nullDevice; > + my $shellArgs = $jsShellArgs . " -f $prefixFile -f resources/sunspider-standalone-driver.js 2> " . File::Spec->devnull(); > my $output; > if ($useShark) { > my $intervalArg = $useShark == 20 ? "-I 20u" : "";
Comment on attachment 40224 [details] proposed patch Clearing flags on attachment: 40224 Committed r48923: <http://trac.webkit.org/changeset/48923>
All reviewed patches have been landed. Closing bug.