RESOLVED FIXED295282
[webkitpy] List 'websocket' as a first class AutoInstall package 
https://bugs.webkit.org/show_bug.cgi?id=295282
Summary [webkitpy] List 'websocket' as a first class AutoInstall package
Lauro Moura
Reported 2025-07-01 09:31:23 PDT
In 288959@main we added a custom Selenium import finder so `run-webdriver-tests` can use the imported selenium version instead of the autoinstalled selenium in `webkitpy` used in other scripts. But, on a clean tree with no autoinstalled packages, the client `websocket` package is not installed, as it's an implicit dependency of selenium. It leads to errors like: ./Tools/Scripts/run-webdriver-tests --verbose --release --wpe --display-server=headless "imported/selenium/py/test/selenium/webdriver/common/api_example_tests.py" <snip> ImportError while loading conftest '/app/webkit/WebDriverTests/imported/selenium/py/conftest.py'. /app/webkit/WebDriverTests/imported/selenium/py/conftest.py:29: in <module> from selenium import webdriver /app/webkit/WebDriverTests/imported/selenium/py/selenium/webdriver/__init__.py:22: in <module> from .remote.webdriver import WebDriver as Remote # noqa /app/webkit/WebDriverTests/imported/selenium/py/selenium/webdriver/remote/webdriver.py:74: in <module> from .websocket_connection import WebSocketConnection /app/webkit/WebDriverTests/imported/selenium/py/selenium/webdriver/remote/websocket_connection.py:23: in <module> from websocket import WebSocketApp # type: ignore E ModuleNotFoundError: No module named 'websocket' webkitpy.webdriver_tests.webdriver_test_runner: [INFO] No tests found webkitpy.webdriver_tests.webdriver_test_runner: [INFO] webkitpy.webdriver_tests.webdriver_test_runner: [INFO] All tests run as expected Patch incoming.
Attachments
Add attachment proposed patch, testcase, etc.
Lauro Moura
Comment 1 2025-07-01 09:35:17 PDT
Pull request: https://github.com/WebKit/WebKit/pull/47442
EWS
Comment 2 2025-07-01 16:26:14 PDT
Committed 296892@main (4d779636fffb): <https://commits.webkit.org/296892@main> Reviewed commits have been landed. Closing PR #47442 and removing active labels.
Radar WebKit Bug Importer
Comment 3 2025-07-01 16:27:15 PDT
<rdar://problem/154806447>
Note You need to log in before you can comment on or make changes to this bug.