Bug 29524 - Implement ES5 Object.create function
Summary: Implement ES5 Object.create function
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2009-09-19 17:54 PDT by Oliver Hunt
Modified: 2009-12-07 05:29 PST (History)
1 user (show)

See Also:


Attachments
Patch v1 (7.89 KB, patch)
2009-09-19 17:57 PDT, Oliver Hunt
mjs: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2009-09-19 17:54:06 PDT
As above
rdar://7214113
Comment 1 Oliver Hunt 2009-09-19 17:57:21 PDT
Created attachment 39829 [details]
Patch v1
Comment 2 Maciej Stachowiak 2009-09-19 18:08:50 PDT
Comment on attachment 39829 [details]
Patch v1

r=me
Comment 3 Oliver Hunt 2009-09-19 18:14:47 PDT
Committed r48568
Comment 4 Erik Corry 2009-12-07 03:59:52 PST
Doesn't seem to work reliably.  The following causes a crash:

function valueGet() { };
var MagicValueProps = { foo: Object.create(null, { value: { get: valueGet }})};
Object.create(null, MagicValueProps)
Comment 5 Oliver Hunt 2009-12-07 05:29:21 PST
This should not have been reopened -- a new bug should have been filed.