Bug 29519 - Remove JSNameNodeCollection and just use StaticNodeList
Summary: Remove JSNameNodeCollection and just use StaticNodeList
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: All OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-19 01:57 PDT by Sam Weinig
Modified: 2009-09-21 18:12 PDT (History)
1 user (show)

See Also:


Attachments
patch (60.19 KB, patch)
2009-09-19 15:24 PDT, Sam Weinig
oliver: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2009-09-19 01:57:02 PDT
JSNameNodeCollection just implements the NodeList interface on top of a Vector of Nodes, which is what StaticNodeList does.  Lets remove JSNameNodeCollection.
Comment 1 Sam Weinig 2009-09-19 15:24:17 PDT
Created attachment 39825 [details]
patch
Comment 2 Oliver Hunt 2009-09-19 15:30:47 PDT
Comment on attachment 39825 [details]
patch

r=me
Comment 3 Eric Seidel (no email) 2009-09-21 14:05:36 PDT
Sad that prototype-inheritance-2 results changed so much (and now there are more types we never crawl to).
Comment 4 Eric Seidel (no email) 2009-09-21 18:12:06 PDT
This was landed over the weekend as r48566.  /me points to "bugzilla-tool land-diff --no-build" as a drop-in "svn commit" replacement which auto-closes bugs. :)