Bug 29516 – [Gtk] WebResource - initialize NULL-valued strings as a String

• Status: RESOLVED
• Resolution: INVALID
• Component: WebKitGTK

[Jan Alonzo]

webkit_web_resource_new doesn't check if values (e.g. encoding, frame name) are NULL. We should initialize these values as String instead of passing null values to ArchiveResource::create.

[Jan Alonzo]

Created attachment 39814 [details]
Patch v1

[Xan Lopez]

Comment on attachment 39814 [details]
Patch v1

String::fromUTF8 already does this:

String String::fromUTF8(const char* string)
{
    if (!string)
        return String();
    return UTF8Encoding().decode(string, strlen(string));
}

Marking as r-.

[Jan Alonzo]

Marking as invalid because this is already handled by String::fromUTF8 as pointed out by Xan.