WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
29510
Active DOM objects should be suspended while a modal dialog is displayed
https://bugs.webkit.org/show_bug.cgi?id=29510
Summary
Active DOM objects should be suspended while a modal dialog is displayed
Alexey Proskuryakov
Reported
2009-09-18 15:18:22 PDT
PageGroupLoadDeferrer calls suspendActiveDOMObjects() on all platforms but Mac, which results in e.g. DOM timers working in a page beneath a modal dialog. This doesn't match Safari for Windows or Firefox, and generally doesn't make much sense. Other active DOM objects also need to be suspended to avoid reentrant JavaScript execution.
Attachments
proposed patch
(3.23 KB, patch)
2009-09-18 15:23 PDT
,
Alexey Proskuryakov
darin
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1
2009-09-18 15:23:09 PDT
Created
attachment 39799
[details]
proposed patch
Alexey Proskuryakov
Comment 2
2009-09-18 15:26:43 PDT
Committed revision 48540. Note that Firefox doesn't fully pass the test - even though timers are disabled while the modal alert and dialog are displayed, they still run while he latter is being created.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug