WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED DUPLICATE of
bug 32538
Bug 29509
svn-create-patch or check-webkit-style should warn about tabs
https://bugs.webkit.org/show_bug.cgi?id=29509
Summary
svn-create-patch or check-webkit-style should warn about tabs
Eric Seidel (no email)
Reported
2009-09-18 15:12:00 PDT
svn-create-patch or check-webkit-style should warn about tabs Right now we only find out about tabs in files/ChangeLogs until commit time. This means reviewers have to manually reject patches due to tabs, or the commit-queue ends up rejecting them later. We need a tighter feedback loop for contributers. This is a common problem for new contributers.
Attachments
Add attachment
proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1
2009-12-03 15:11:27 PST
This is extra annoying now that we have the style-queue which should be catching this type of thing:
https://bugs.webkit.org/show_bug.cgi?id=32100#c5
Eric Seidel (no email)
Comment 2
2009-12-03 15:11:35 PST
***
Bug 32039
has been marked as a duplicate of this bug. ***
David Levin
Comment 3
2009-12-16 12:17:23 PST
Resolving as a dup of a later bug since that other bug has the patch with a fix for svn-create-patch or check-webkit-style should warn about tabs and that seems like a good place for this. *** This bug has been marked as a duplicate of
bug 32538
***
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug