Bug 29509 - svn-create-patch or check-webkit-style should warn about tabs
Summary: svn-create-patch or check-webkit-style should warn about tabs
Status: RESOLVED DUPLICATE of bug 32538
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
: 32039 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-09-18 15:12 PDT by Eric Seidel (no email)
Modified: 2009-12-16 12:17 PST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2009-09-18 15:12:00 PDT 
svn-create-patch or check-webkit-style should warn about tabs

Right now we only find out about tabs in files/ChangeLogs until commit time.  This means reviewers have to manually reject patches due to tabs, or the commit-queue ends up rejecting them later.  We need a tighter feedback loop for contributers.  This is a common problem for new contributers.
Comment 1 Eric Seidel (no email) 2009-12-03 15:11:27 PST 
This is extra annoying now that we have the style-queue which should be catching this type of thing:
https://bugs.webkit.org/show_bug.cgi?id=32100#c5
Comment 2 Eric Seidel (no email) 2009-12-03 15:11:35 PST 
*** Bug 32039 has been marked as a duplicate of this bug. ***
Comment 3 David Levin 2009-12-16 12:17:23 PST 
Resolving as a dup of a later bug since that other bug has the patch with a fix for svn-create-patch or check-webkit-style should warn about tabs and that seems like a good place for this.

*** This bug has been marked as a duplicate of bug 32538 ***