Bug 29507 – Add MarkStackSymbian.cpp to build JavascriptCore for Symbian.

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Yongjun Zhang]

MarkStack has platform specific implementations for windows and posix based port.  Symbian port needs to have Symbian specific MarkStack implementation to get JavaScriptCore compile.

[Yongjun Zhang]

Created attachment 39788 [details]
add MarkStackSymbian.cpp and reuse windows port's shrinkAllocation().

Re-use Windows shrinkAllocation implementation because Symbian doesn't support releasing part of memory region.      

Use fastMalloc and fastFree to implement allocateStack and releaseStack for Symbian port.

[Eric Seidel (no email)]

Comment on attachment 39788 [details]
add MarkStackSymbian.cpp and reuse windows port's shrinkAllocation().

Seems like a lot of headers to include for such a simple .cpp file.  I don't know if fastMalloc/fastFree will behave as you want them to or not.  But I'm happy to r+ a patch with them in it as, you'll figure out very quickly if they're broken. ;)

releaseStack ignores the "size" argument.  Most of WebCore builds with -Wunused enabled, if symbian ever turns that warning back on, this will break.

I'm not sure why Apple's copyright is copied into this tiny file.

I think normally we have an extra line after the corresponding header include, in this case, I would expect a new line after 
+#include "MarkStack.h"

r- for the above mentioned nits.

[Yongjun Zhang]

Created attachment 39996 [details]
Modified patch as per Eric's comments.

thanks for the comments, Eric.

In the modified patch, I copied the copyright notice from files in Qt port to keep it consistent.

[Eric Seidel (no email)]

Comment on attachment 39996 [details]
Modified patch as per Eric's comments.

What is this supposed to mean?
 2     Copyright (C) 2009 Nokia Corporation and/or its subsidiary(-ies)
I've never seen such a copyright line.  If you're intending to assign copyright to a specific entity, please list that entity.

[Janne Koskinen]

> I've never seen such a copyright line.  If you're intending to assign copyright
> to a specific entity, please list that entity.

Then you haven't been paying attention to what is going on in the trunk ;)
That copyright is all over the place in webkit code.

[Yongjun Zhang]

Comment on attachment 39996 [details]
Modified patch as per Eric's comments.

Hi Eric,

I agree the copyright line looks a bit uncommon.  It was however drafted by Nokia/Trolltech legal and is currently used in all Qt port files under WebKit/Qt.

thanks.

[Simon Hausmann]

Comment on attachment 39996 [details]
Modified patch as per Eric's comments.

r=me

[Simon Hausmann]

Committed r48788: <http://trac.webkit.org/changeset/48788>