Bug 29503 - Implement ES5 Object.defineProperty function
Summary: Implement ES5 Object.defineProperty function
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
Keywords: InRadar
Depends on:
Reported: 2009-09-18 13:54 PDT by Oliver Hunt
Modified: 2009-09-18 16:12 PDT (History)
0 users

See Also:

Implement ES5 Object.defineProperty function (87.91 KB, patch)
2009-09-18 14:51 PDT, Oliver Hunt
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2009-09-18 13:54:01 PDT
as in title
Comment 1 Oliver Hunt 2009-09-18 13:54:50 PDT
Comment 2 Oliver Hunt 2009-09-18 14:51:48 PDT
Created attachment 39791 [details]
Implement ES5 Object.defineProperty function


Reviewed by NOBODY(OOPS!)

Implement Object.defineProperty.  This requires adding the API to
ObjectConstructor, along with a helper function that implements the
ES5 internal [[ToPropertyDescriptor]] function.  It then adds
JSObject::defineOwnProperty that implements the appropriate ES5 semantics.
Currently defineOwnProperty uses a delete followed by a put to redefine
attributes of a property, clearly this is less efficient than it could be
but we can improve this if it needs to be possible in future.
 33 files changed, 921 insertions(+), 73 deletions(-)
Comment 3 Geoffrey Garen 2009-09-18 15:27:39 PDT
Comment on attachment 39791 [details]
Implement ES5 Object.defineProperty function

Comment 4 Oliver Hunt 2009-09-18 16:12:22 PDT
Committed r48542