Bug 29499 - Coding style guidelines should standardize on "using namespace" positioning
Summary: Coding style guidelines should standardize on "using namespace" positioning
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Website (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-18 11:38 PDT by Brady Eidson
Modified: 2009-09-21 19:17 PDT (History)
2 users (show)

See Also:

Attachments
Proposed guidelines (1.83 KB, patch)
2009-09-18 11:39 PDT, Brady Eidson 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2009-09-18 11:38:39 PDT 
"using namespace" statements are positions in a very inconsistent manner throughout WebCore - sometimes before a defined namespace, and sometimes within that defined namespace.

The coding style guidelines should specify a standard place to put these.
Comment 1 Brady Eidson 2009-09-18 11:39:56 PDT 
Created attachment 39771 [details]
Proposed guidelines
Comment 2 Darin Adler 2009-09-18 11:49:48 PDT 
I like this guideline, but I think we should have a brief webkit-dev discussion before landing the change.
Comment 3 Brady Eidson 2009-09-18 12:07:40 PDT 
Agreed, I will send an email out
Comment 4 Brady Eidson 2009-09-21 17:14:31 PDT 
This proposal hasn't received any objections, so I'd like to land it.
Comment 5 Darin Adler 2009-09-21 18:28:38 PDT 
I noticed a double period ".." somewhere in this patch. You should fix that when landing.
Comment 6 Eric Seidel (no email) 2009-09-21 18:43:04 PDT 
Agreed, I think this is a great thing to put in the style guide. :)
Comment 7 Brady Eidson 2009-09-21 19:16:56 PDT 
Committed rr48616: <http://trac.webkit.org/changeset/r48616>
Comment 8 Brady Eidson 2009-09-21 19:17:42 PDT 
`bugzilla-tool mark-fixed` beats me again...

Committed r48616: <http://trac.webkit.org/changeset/48616>