Bug 29494 - HTMLMediaElement m_playedTimeRanges can be NULL
Summary: HTMLMediaElement m_playedTimeRanges can be NULL
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-18 10:15 PDT by Eric Carlson
Modified: 2009-09-18 11:48 PDT (History)
0 users

See Also:


Attachments
proposed patch (3.71 KB, patch)
2009-09-18 10:28 PDT, Eric Carlson
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2009-09-18 10:15:01 PDT
m_playedTimeRanges is initialized in HTMLMediaElement::loadInternal and assumed to be non-NULL everywhere it is used. This does not work when PLUGIN_PROXY_FOR_VIDEO is defined, because loadInternal is never called.
Comment 1 Eric Carlson 2009-09-18 10:28:08 PDT
Created attachment 39767 [details]
proposed patch
Comment 2 Darin Adler 2009-09-18 10:36:58 PDT
Comment on attachment 39767 [details]
proposed patch

Can we have a regression test for this?
Comment 3 Eric Carlson 2009-09-18 11:47:52 PDT
A regression test isn't possible on the desktop because none of the ports build with PLUGIN_PROXY_FOR_VIDEO defined.
Comment 4 Eric Carlson 2009-09-18 11:48:09 PDT
http://trac.webkit.org/changeset/48519