Bug 29493 – [LTTF] Comprehensive testing of button rendering

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Karen]

adding layout test for Chromium. This is a basic test that checks button rendering.

[Karen]

Created attachment 39765 [details]
basic button layout test patch

[Karen]

Created attachment 39766 [details]
fixed the changelog - basic button layout test for chromium.

[Karen]

patch coming.

[Karen]

Created attachment 39774 [details]
basic button layout test patch

there's a problem with the buttons not rendering the same on Mac vs PC. This patch just contains the HTML file. I will add the others as soon as I get information on what to do. please see bug for more details.

[Karen]

Created attachment 39775 [details]
screen shot of the mac rendering, the buttons with text are ignoring the padding and the one with image are inconsistent.

[Karen]

Hi,

This is a basic layout test chromium uses to check for proper button rendering. If you look at the results on a mac vs PC, you will see different results. The PC version renders both the image and text buttons with the proper padding. The Mac version doesn't add any padding to the text button and two of the paddings (10% and 2px) on the image button appear different than the rest. (see attached PNG file)

I included the html file in the patch and will wait for further instructions before I submit full patch with expected.txt, png, checksum files.

thank you.

[Eric Seidel (no email)]

Comment on attachment 39774 [details]
basic button layout test patch

expected.png and expected.checksum are missing from your patch.

What is this test for?  Please explain in your ChangeLog.  What does this test cover that other tests do not already?

[Eric Seidel (no email)]

(In reply to comment #7)
> (From update of attachment 39774 [details])
> expected.png and expected.checksum are missing from your patch.
> 
> What is this test for?  Please explain in your ChangeLog.  What does this test
> cover that other tests do not already?

Looks like you explained some of this in the bug, but the ChangeLog needs more of this info.

[Karen]

Created attachment 39930 [details]
tests basic buttons comprehensively. added expected files, fixed changelog.

cleaned up patch. added comment to html, generated expected results and cleaned changelog.

[Dimitri Glazkov (Google)]

Comment on attachment 39930 [details]
tests basic buttons comprehensively. added expected files, fixed changelog.

looks good, except for:

> +function printSize(tagname, cell) {

brace on new line for functions.

[Karen]

Created attachment 40023 [details]
basic button layout test patch - fixed brace to be on new line

fixed function brace to be on a new line.

[Dimitri Glazkov (Google)]

Comment on attachment 40023 [details]
basic button layout test patch - fixed brace to be on new line

I just realized that all indents are 2-space here :)

[Karen]

Created attachment 40025 [details]
basic button layout test patch - changed to have 4 space indents 

changed the file to have 4-space indents

[Dimitri Glazkov (Google)]

Comment on attachment 40025 [details]
basic button layout test patch - changed to have 4 space indents 


> +     return '<tr><td>' + (style || '(default)') + '</td>' +
> +    '<td><button ' + (style ? 'style="' + style + '"' : '') + '>' + fooImage + '</button></td>' +
> +    '<td></td>' +
> +    '<td><input type="button" value="foo" style="' + style + '"></td>' +
> +    '<td></td></tr>';

Extra 4 spaces. Sorry :)

[Karen]

Created attachment 40026 [details]
basic button layout test patch - changed to have 4 space indents 

fixed indenting

[Dimitri Glazkov (Google)]

Comment on attachment 40026 [details]
basic button layout test patch - changed to have 4 space indents 

r=me.

[WebKit Commit Bot]

Comment on attachment 40026 [details]
basic button layout test patch - changed to have 4 space indents 

Clearing flags on attachment: 40026

Committed r48690: <http://trac.webkit.org/changeset/48690>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Eric Seidel (no email)]

It looks like the commit-queue failed to land the .png file due to bug 29622.  This is bad. :(   Re-opening.  I'll take care of fixing things.

[WebKit Commit Bot]

Committed r48696: <http://trac.webkit.org/changeset/48696>

[Eric Seidel (no email)]

Sorry, that wasn't actually the commit-queue making the commit.  I just happened to borrow the commit bot's checkout to do the commit. :(