This bug report originated from issue QTBUG-3121 <http://bugreports.qt.nokia.com/browse/QTBUG-3121> --- Description --- Support for 4.3 should be removed. We should only support for the two stable releases, 4.4 and 4.5 (upcoming).
Created attachment 43342 [details] remove support for Qt 4.3 or earlier version
Comment on attachment 43342 [details] remove support for Qt 4.3 or earlier version Great patch!
Comment on attachment 43342 [details] remove support for Qt 4.3 or earlier version Rejecting patch 43342 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 11628 test cases. fast/workers/worker-terminate.html -> crashed Exiting early after 1 failures. 8414 tests run. 253.07s total testing time 8413 test cases (99%) succeeded 1 test case (<1%) crashed 3 test cases (<1%) had stderr output
Comment on attachment 43342 [details] remove support for Qt 4.3 or earlier version Sigh. Bug 31461.
Comment on attachment 43342 [details] remove support for Qt 4.3 or earlier version Rejecting patch 43342 from commit-queue. Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Kenneth Rohde Christiansen', '--force']" exit_code: 1 Last 500 characters of output: n.cpp Hunk #1 FAILED at 40. Hunk #2 succeeded at 274 (offset 62 lines). Hunk #3 succeeded at 374 (offset 62 lines). Hunk #4 succeeded at 567 (offset 62 lines). 1 out of 4 hunks FAILED -- saving rejects to file WebKit/qt/QtLauncher/main.cpp.rej patching file WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp patching file WebKitTools/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file WebKitTools/DumpRenderTree/qt/DumpRenderTree.pro patching file WebKitTools/DumpRenderTree/qt/ImageDiff.pro
It looks like the patch bit-rotted while they commit-queue was down. Sorry. :( The commit-queue is back, so if you post an updated patch it will be landed immediately after review this time.
Actually I think Laszlo is a committer, so he can update and land his own patch. :)
Landed as http://trac.webkit.org/changeset/51174.