Bug 29469 - [Qt] Remove support for Qt v4.3 or older versions
Summary: [Qt] Remove support for Qt v4.3 or older versions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other All
: P2 Enhancement
Assignee: Nobody
URL:
Keywords: Qt
Depends on:
Blocks:
 
Reported: 2009-09-18 08:28 PDT by Tor Arne Vestbø
Modified: 2009-11-19 06:32 PST (History)
3 users (show)

See Also:


Attachments
remove support for Qt 4.3 or earlier version (119.50 KB, patch)
2009-11-16 21:02 PST, Laszlo Gombos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tor Arne Vestbø 2009-09-18 08:28:09 PDT
This bug report originated from issue QTBUG-3121
<http://bugreports.qt.nokia.com/browse/QTBUG-3121>

--- Description ---

Support for 4.3 should be removed. We should only support for the two stable releases, 4.4 and 4.5 (upcoming).
Comment 1 Laszlo Gombos 2009-11-16 21:02:38 PST
Created attachment 43342 [details]
remove support for Qt 4.3 or earlier version
Comment 2 Kenneth Rohde Christiansen 2009-11-17 05:40:37 PST
Comment on attachment 43342 [details]
remove support for Qt 4.3 or earlier version

Great patch!
Comment 3 WebKit Commit Bot 2009-11-17 12:58:01 PST
Comment on attachment 43342 [details]
remove support for Qt 4.3 or earlier version

Rejecting patch 43342 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1
Running build-dumprendertree
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 11628 test cases.
fast/workers/worker-terminate.html -> crashed

Exiting early after 1 failures. 8414 tests run.
253.07s total testing time

8413 test cases (99%) succeeded
1 test case (<1%) crashed
3 test cases (<1%) had stderr output
Comment 4 Eric Seidel (no email) 2009-11-17 13:05:28 PST
Comment on attachment 43342 [details]
remove support for Qt 4.3 or earlier version

Sigh.  Bug 31461.
Comment 5 WebKit Commit Bot 2009-11-18 14:52:09 PST
Comment on attachment 43342 [details]
remove support for Qt 4.3 or earlier version

Rejecting patch 43342 from commit-queue.

Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Kenneth Rohde Christiansen', '--force']" exit_code: 1
Last 500 characters of output:
n.cpp
Hunk #1 FAILED at 40.
Hunk #2 succeeded at 274 (offset 62 lines).
Hunk #3 succeeded at 374 (offset 62 lines).
Hunk #4 succeeded at 567 (offset 62 lines).
1 out of 4 hunks FAILED -- saving rejects to file WebKit/qt/QtLauncher/main.cpp.rej
patching file WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp
patching file WebKitTools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file WebKitTools/DumpRenderTree/qt/DumpRenderTree.pro
patching file WebKitTools/DumpRenderTree/qt/ImageDiff.pro
Comment 6 Eric Seidel (no email) 2009-11-18 15:00:19 PST
It looks like the patch bit-rotted while they commit-queue was down.  Sorry. :(  The commit-queue is back, so if you post an updated patch it will be landed immediately after review this time.
Comment 7 Eric Seidel (no email) 2009-11-18 15:00:45 PST
Actually I think Laszlo is a committer, so he can update and land his own patch. :)
Comment 8 Laszlo Gombos 2009-11-19 06:32:00 PST
Landed as http://trac.webkit.org/changeset/51174.