Bug 294317 – [WPEPlatform] Introduce support for Android's AHardwareBuffer

• Status: RESOLVED
• Resolution: FIXED
• Component: WPE WebKit

[Adrian Perez]

The same way we have a WPEBufferDMABuf, we would want to have a WPEBuffer subclass to wrap Android's AHardwareBuffer. 

One question is what to do when building for non-Android systems. One option is to have the implementation contain stubs that error out, the other to avoid building the Android-specific code at all.

[Carlos Garcia Campos]

What we do for the builtin platforms, that are optional and have public API, is that and ifdef is needed to use them, see WPEConfig.h.in where we define (or not) WPE_PLATFORM_WAYLAND, WPE_PLATFORM_DRM and WPE_PLATFORM_HEADLESS. So, to use for example wpe_screen_drm_get_crtc_index() in DisplayVBlankMonitorDRM.cpp we need to add #ifdef WPE_PLATFORM_DRM. This could be something similar.

[Adrian Perez]

Pull request: https://github.com/WebKit/WebKit/pull/46598

[Adrian Perez]

(In reply to Carlos Garcia Campos from comment #1)
> What we do for the builtin platforms, that are optional and have public API,
> is that and ifdef is needed to use them, see WPEConfig.h.in where we define
> (or not) WPE_PLATFORM_WAYLAND, WPE_PLATFORM_DRM and WPE_PLATFORM_HEADLESS.
> So, to use for example wpe_screen_drm_get_crtc_index() in
> DisplayVBlankMonitorDRM.cpp we need to add #ifdef WPE_PLATFORM_DRM. This
> could be something similar.

Thanks for the pointer, I'll take a look. For now I have posted the PR as a draft and will update it when I have the needed changes applied.

[EWS]

Committed 298619@main (fd72faeef06a): <https://commits.webkit.org/298619@main>

Reviewed commits have been landed. Closing PR #46598 and removing active labels.