RESOLVED FIXED294287
[webkitpy] Move default CURRENT_VERSION variable definition to DarwinPort. 
https://bugs.webkit.org/show_bug.cgi?id=294287
Summary [webkitpy] Move default CURRENT_VERSION variable definition to DarwinPort.
Ben Schwartz
Reported 2025-06-10 14:49:28 PDT
Currently, many of our unit tests feature hard-coded Version objects for testing the latest major OS versions. This requires changes to these unit tests each year, which is pretty inefficient. Instead, we should take the value of CURRENT_VERSION on the Port object to determine this. (We already do this in some places.)
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2025-06-10 14:49:36 PDT
<rdar://problem/153002661>
Ben Schwartz
Comment 2 2025-06-11 17:41:05 PDT
After thinking about this a bit more, now that all Apple port versions are 26, we can probably just define this in DarwinPort and override in subclasses in edge cases.
Ben Schwartz
Comment 3 2025-06-11 18:06:18 PDT
Pull request: https://github.com/WebKit/WebKit/pull/46637
EWS
Comment 4 2025-06-17 18:13:56 PDT
Committed 296346@main (71871b592a2f): <https://commits.webkit.org/296346@main> Reviewed commits have been landed. Closing PR #46637 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.