Bug 294269 – Korean counter styles aren't aligned with manual Korean numbering in lists.

• Status: RESOLVED
• Resolution: FIXED
• Component: Text

[Ian Gower]

Created attachment 475523 [details]
Isolated test case demonstrating the alignment error for the Korean counter-styles.

When displaying a list using any Korean counter style, the alignment differs from a list that manually labels items with the same Korean numbers. Specifically, lists with a Korean counter style show no extra spacing between entries. In contrast, lists without a counter style—but with the same Korean text inserted manually—introduce extra spacing between items. This discrepancy is evident in the attached test case.

I discovered this issue while expanding the range for Chinese, Japanese, and Korean counter styles. The spacing inconsistency is specifically affecting the Korean styles and is currently preventing those test cases from passing.( https://github.com/WebKit/WebKit/pull/46446 )

[Radar WebKit Bug Importer]

<rdar://problem/152969810>

[alan]

Created attachment 475525 [details]
Test reduction

[fantasai]

Created attachment 475528 [details]
horizontal spacing testcase (irrelevant)

[fantasai]

Comment on attachment 475528 [details]
horizontal spacing testcase (irrelevant)

Nm, I was looking at the wrong axis. :)

[fantasai]

Alright, what's happening here is that the ::marker text is not contributing to the line height, but the <bdi> element (or its contents) are.

The workaround for this would be to apply line-height: 1;, but, it's an interesting question of why we have this interference and e.g. Firefox does not.

[fantasai]

Created attachment 475529 [details]
weird testcase variant

It seems like we are doing weird things with line-height here?

[alan]

Created attachment 475531 [details]
Fixed -screenshot

All test cases are fixed (will upload the patch soon) but while the original test case was about fallback fonts, the "weird testcase variant" is a very different issue (list markers consult their parent list items for their baseline) so I am going to file a new bugzilla for that.

[alan]

Created attachment 475538 [details]
Patch

[alan]

Created attachment 475541 [details]
Patch

[alan]

Created attachment 475542 [details]
Patch

[alan]

Created attachment 475544 [details]
Patch

[Antti Koivisto]

Comment on attachment 475544 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=475544&action=review

> Source/WebCore/layout/integration/LayoutIntegrationBoxGeometryUpdater.cpp:497
> +            const_cast<Layout::ElementBox&>(layoutBox).setListMarkerLayoutBounds(renderListMarker->layoutBounds());

:sad:

[alan]

Created attachment 475553 [details]
Patch

[alan]

Created attachment 475564 [details]
[fast-cq]Patch

[EWS]

Committed 296203@main (78c26be44142): <https://commits.webkit.org/296203@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 475564 [details].