Bug 294206 – Fix computed value for `marker` (SVG)

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Ahmad Saleem]

Hi Team,

Similar to bug 294199, it seems that we fail `computed` value in case of `marker` as well:

Test Case: https://wpt.fyi/results/svg/painting/parsing/marker-computed.svg?label=experimental&label=master&aligned

Test Case Live Link: http://wpt.live/svg/painting/parsing/marker-computed.svg

WebKit Source: https://searchfox.org/wubkat/rev/47cd65b85abfaf60c97296ea375c3c24e05a9b27/Source/WebCore/css/CSSProperties.json#5453

"marker": {
            "inherited": true,
            "codegen-properties": {
                "longhands": [
                    "marker-start",
                    "marker-mid",
                    "marker-end"
                ],
                "skip-style-extractor": true,
                "skip-style-extractor-comment": "FIXME: Figure out and document why this has no computed value",
                "parser-function": "consumeMarkerShorthand",
                "parser-grammar-unused": "<'marker-start'>",
                "parser-grammar-unused-reason": "Needs support for shorthand grammars."
            },
            "specification": {
                "category": "svg",
                "url": "https://www.w3.org/TR/SVG/painting.html#MarkerProperty"
            }
        },

Same root cause:

"skip-style-extractor": true,
"skip-style-extractor-comment": "FIXME: Figure out and document why this has no computed value",

____

I think we can fix it - if we figure out how new automated generated code works and by removing these lines or using custom style extractor.

Just raising for now to track it.

Thanks!

[Radar WebKit Bug Importer]

<rdar://problem/153373245>

[Ahmad Saleem]

Pull request: https://github.com/WebKit/WebKit/pull/46758

[Rob Buis]

Pull request: https://github.com/WebKit/WebKit/pull/51122

[EWS]

Committed 301462@main (a04206ec3b04): <https://commits.webkit.org/301462@main>

Reviewed commits have been landed. Closing PR #51122 and removing active labels.

[Ahmad Saleem]

Submitted web-platform-tests pull request: https://github.com/web-platform-tests/wpt/pull/56022