WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
294041
[Style] Use strong Style value types for size types width, height, min-width, min-height, max-width, max-height, and flex-basis
https://bugs.webkit.org/show_bug.cgi?id=294041
Summary
[Style] Use strong Style value types for size types width, height, min-width,...
Sam Weinig
Reported
2025-06-04 12:10:39 PDT
Add wrappers (for now) of WebCore::Length for the size types width, height, min-width, min-height, max-width, max-height, and flex-basis. This will allow us to enforce at the type level which keywords and value ranges are supported for each type and make the code a bit more clear.
Attachments
Add attachment
proposed patch, testcase, etc.
Sam Weinig
Comment 1
2025-06-04 12:18:01 PDT
Comment hidden (obsolete)
Pull request:
https://github.com/WebKit/WebKit/pull/46336
Sam Weinig
Comment 2
2025-06-08 08:58:54 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/46476
EWS
Comment 3
2025-06-10 10:37:17 PDT
Committed
296045@main
(4bf6d54fbdaf): <
https://commits.webkit.org/296045@main
> Reviewed commits have been landed. Closing PR #46476 and removing active labels.
Radar WebKit Bug Importer
Comment 4
2025-06-10 10:38:13 PDT
<
rdar://problem/152975426
>
Robert Jenner
Comment 5
2025-06-10 12:02:19 PDT
Reopened Bugzilla. [Style] Use strong Style value types for size types width, height, min-width, min-height, max-width, max-height, and flex-basis, tracking revert in
https://bugs.webkit.org/show_bug.cgi?id=294041
.
EWS
Comment 6
2025-06-10 12:06:05 PDT
Committed
296049@main
(3f246c674828): <
https://commits.webkit.org/296049@main
> Reviewed commits have been landed. Closing PR #46558 and removing active labels.
Robert Jenner
Comment 7
2025-06-10 12:10:13 PDT
https://commits.webkit.org/296045@main
broke all apple builds. We had to revert it. Please hold, as we are upstreaming changes shortly to prep for re-landing this.
Sam Weinig
Comment 8
2025-06-12 10:19:42 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/46665
EWS
Comment 9
2025-06-12 17:31:38 PDT
Committed
296172@main
(eedb96ae03e8): <
https://commits.webkit.org/296172@main
> Reviewed commits have been landed. Closing PR #46665 and removing active labels.
Sam Weinig
Comment 10
2025-09-27 08:51:04 PDT
***
Bug 286245
has been marked as a duplicate of this bug. ***
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug