RESOLVED FIXED293978
Replace hard coded @"NSErrorFailingURLKey" in favor of the framework NSURLErrorFailingURLErrorKey symbol 
https://bugs.webkit.org/show_bug.cgi?id=293978
Summary Replace hard coded @"NSErrorFailingURLKey" in favor of the framework NSURLErr...
Brent Fulgham
Reported 2025-06-03 12:40:14 PDT
WebKit hardcoded the string value @"NSErrorFailingURLKey" in many places, probably before Foundation standardized on the `NSURLErrorFailingURLErrorKey` symbol in macOS 10.6 (and iOS 4.0). We should use this framework symbol rather than the string value.
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2025-06-03 12:40:34 PDT
<rdar://problem/152520483>
Brent Fulgham
Comment 2 2025-06-03 12:42:56 PDT
Note: `NSURLErrorFailingURLErrorKey` is defined as @"NSErrorFailingURLKey".
Brent Fulgham
Comment 3 2025-06-03 12:58:04 PDT
The deprecated `NSURLErrorFailingURLStringErrorKey` symbol is defined as @"NSErrorFailingURLStringKey". We should probably remove its use in a future patch.
Brent Fulgham
Comment 4 2025-06-03 14:23:06 PDT
PR: https://github.com/WebKit/WebKit/pull/46280
EWS
Comment 5 2025-06-06 09:41:36 PDT
Committed 295919@main (174717c86b54): <https://commits.webkit.org/295919@main> Reviewed commits have been landed. Closing PR #46280 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.