Bug 29391 – [Qt] QtWebKit: ESC key does not clear the text of the line edit when canceling an input method

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Tor Arne Vestbø]

This bug report originated from issue QTBUG-2580
<http://bugreports.qt.nokia.com/browse/QTBUG-2580>

--- Description ---

When using the 'scim' (and possibly others) input method to enter text into a QLineEdit, the normal behavior is that pressing the 'Esc' key will close the input method and clear the text. This works in normal line edits, but does not work properly when entering the text in a line edit on a webpage because the input method is closed, but the text is not cleared.

[Jocelyn Turcotte]

Reproduced on Windows 7 IME with Qt 4.7 and WebKit r55520

I'm setting the priority by guessing to P3, I don't use IME often so if somebody confirms that this can be annoying we can reevaluate the priority.

[Jan Erik Hanssen]

Created attachment 76926 [details]
Patch

The problem is that the composition text is never cleared while it should be when the editor is in composition mode and an empty QInputMethodEvent is received

[Alexey Proskuryakov]

Can a regression test be added for this? We have some ways to simulate input method behavior in DumpRenderTree, although I don't know if those work with Qt.

[Jan Erik Hanssen]

Created attachment 77250 [details]
Patch

Change the Qt test case to a generic one

[Alexey Proskuryakov]

Comment on attachment 77250 [details]
Patch

Thanks for making a nice regression test!

[WebKit Commit Bot]

Comment on attachment 77250 [details]
Patch

Clearing flags on attachment: 77250

Committed r74605: <http://trac.webkit.org/changeset/74605>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Jessie Berlin]

The new test should also have been added to the skip list for Windows, since DRT's textInputController is unimplemented on Windows: https://bugs.webkit.org/show_bug.cgi?id=32021

I will land the change to the windows skip list shortly.

[Jessie Berlin]

Committed the change to the Windows Skip list in r74641:
http://trac.webkit.org/changeset/74641

[Eric Seidel (no email)]

Chromium is fixing their port to match this test in bug 51693.