Bug 29367 - memory leak in JavaScriptCore RegisterFile on Windows CE
Summary: memory leak in JavaScriptCore RegisterFile on Windows CE
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 523.x (Safari 3)
Hardware: Other Other
: P1 Major
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-18 04:12 PDT by Joerg Bornemann
Modified: 2009-09-22 08:11 PDT (History)
2 users (show)

See Also:


Attachments
mem leak fix (1.08 KB, patch)
2009-09-18 04:12 PDT, Joerg Bornemann
no flags Details | Formatted Diff | Diff
Updated patch with ChangeLog (1.32 KB, patch)
2009-09-19 10:45 PDT, Simon Hausmann
hausmann: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joerg Bornemann 2009-09-18 04:12:38 PDT
Created attachment 39756 [details]
mem leak fix

On Widows CE we must decommit all committed pages before we release
them. See VirtualFree documentation.
Desktop Windows behaves much smoother in this situation.
Comment 1 Joerg Bornemann 2009-09-18 04:14:11 PDT
Without this patch we leak 2 MB every time after destroying a JSC instance on Windows CE.
Comment 2 Simon Hausmann 2009-09-18 05:54:12 PDT
Comment on attachment 39756 [details]
mem leak fix

Changed requested eviewer to George, to be sure this won't conflict with the other Windows CE port.
Comment 3 Simon Hausmann 2009-09-18 05:54:44 PDT
George, do you know if that would help or conflict with your CE port?
Comment 4 Simon Hausmann 2009-09-19 10:45:25 PDT
Created attachment 39822 [details]
Updated patch with ChangeLog

New patch with fixed paths and ChangeLog
Comment 5 Simon Hausmann 2009-09-22 03:30:04 PDT
Comment on attachment 39822 [details]
Updated patch with ChangeLog

Joerg explained the change in all detail to me and it seems like the right thing to do. George, please holler if you notice any issues with it.
Comment 6 Simon Hausmann 2009-09-22 03:47:53 PDT
Landed in r48623
Comment 7 George Staikos 2009-09-22 07:03:47 PDT
Yes it's fine.  SHould have been Yong reviewing this :)  Oh, and it's only really an issue if you load/unload the dll.
Comment 8 Joerg Bornemann 2009-09-22 08:11:27 PDT
(In reply to comment #7)
> Yes it's fine.  SHould have been Yong reviewing this :)  Oh, and it's only
> really an issue if you load/unload the dll.

Or if you create / destroy QScriptEngine objects. ;-)