Bug 29364 - SourceCode() does not initialize m_provider
Summary: SourceCode() does not initialize m_provider
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P3 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-18 02:24 PDT by Jędrzej Nowacki
Modified: 2009-09-21 13:37 PDT (History)
2 users (show)

See Also:

Attachments
patch resolving problem (1.11 KB, patch)
2009-09-18 02:28 PDT, Jędrzej Nowacki 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jędrzej Nowacki 2009-09-18 02:24:19 PDT 
Default constructor of SourceCode class doesn't initialize m_provider member. It could be source of problems in future. Right now nobody use it...
Comment 1 Jędrzej Nowacki 2009-09-18 02:28:44 PDT 
Created attachment 39753 [details]
patch resolving problem
Comment 2 Alexey Proskuryakov 2009-09-18 11:39:15 PDT 
Please mark the patch for review by clicking "Details" link to the right of it, and changing review flag to "?".
Comment 3 Jędrzej Nowacki 2009-09-21 00:03:04 PDT 
(In reply to comment #2)
> Please mark the patch for review by clicking "Details" link to the right of it,
> and changing review flag to "?".

Done
Comment 4 Eric Seidel (no email) 2009-09-21 13:18:47 PDT 
Comment on attachment 39753 [details]
patch resolving problem

That seems like a rather needlessly verbose ChangeLog entry.  I think all I would have said was:

Fix SourceCode() to initialize m_provider.
https://bugs.webkit.org/show_bug.cgi?id=29364

This is OK though.  Since you're not a committer I'll assume you wanted cq=? and set cq+ for you.
Comment 5 WebKit Commit Bot 2009-09-21 13:37:23 PDT 
Comment on attachment 39753 [details]
patch resolving problem

Clearing flags on attachment: 39753

Committed r48593: <http://trac.webkit.org/changeset/48593>
Comment 6 WebKit Commit Bot 2009-09-21 13:37:28 PDT 
All reviewed patches have been landed.  Closing bug.