WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
293630
ClientCertificateAuthenticationXPCConstants.cpp is missing include of ASCIILiteral.h
https://bugs.webkit.org/show_bug.cgi?id=293630
Summary
ClientCertificateAuthenticationXPCConstants.cpp is missing include of ASCIILi...
David Kilzer (:ddkilzer)
Reported
2025-05-27 12:20:45 PDT
Summary: Source/WebKit/Shared/Authentication/cocoa/ClientCertificateAuthenticationXPCConstants.cpp is missing `#include <wtf/text/ASCIILiteral.h>` for some build configurations. ``` [stdout] 25-05-27 09:26:41 In file included from OpenSource/WebKitBuild/Release/DerivedSources/WebKit/unified-sources/UnifiedSource65.cpp:1: [stdout] 25-05-27 09:26:41 OpenSource/Source/WebKit/Shared/Authentication/cocoa/ClientCertificateAuthenticationXPCConstants.cpp:35:55: error: no matching literal operator for call to 'operator""_s' with arguments of types 'const char *' and 'unsigned long', and no matching literal operator template [stdout] 25-05-27 09:26:41 35 | const ASCIILiteral XPCCertificatesKey = "certificates"_s; [stdout] 25-05-27 09:26:41 | ^ [stdout] 25-05-27 09:26:41 OpenSource/Source/WebKit/Shared/Authentication/cocoa/ClientCertificateAuthenticationXPCConstants.cpp:35:20: error: variable has incomplete type 'const ASCIILiteral' [stdout] 25-05-27 09:26:41 35 | const ASCIILiteral XPCCertificatesKey = "certificates"_s; [stdout] 25-05-27 09:26:41 | ^ [stdout] 25-05-27 09:26:41 In file included from OpenSource/WebKitBuild/Release/DerivedSources/WebKit/unified-sources/UnifiedSource65.cpp:1: [stdout] 25-05-27 09:26:41 In file included from OpenSource/Source/WebKit/Shared/Authentication/cocoa/ClientCertificateAuthenticationXPCConstants.cpp:26: [stdout] 25-05-27 09:26:41 In file included from OpenSource/Source/WebKit/config.h:41: [stdout] 25-05-27 09:26:41 In file included from OpenSource/WebKitBuild/Release/usr/local/include/wtf/FastMalloc.h:26: [stdout] 25-05-27 09:26:41 In file included from OpenSource/WebKitBuild/Release/usr/local/include/wtf/MallocCommon.h:29: [stdout] 25-05-27 09:26:41 In file included from OpenSource/WebKitBuild/Release/usr/local/include/wtf/StdLibExtras.h:50: [stdout] 25-05-27 09:26:41 In file included from OpenSource/WebKitBuild/Release/usr/local/include/wtf/TypeTraits.h:34: [stdout] 25-05-27 09:26:41 OpenSource/WebKitBuild/Release/usr/local/include/wtf/Forward.h:36:7: note: forward declaration of 'WTF::ASCIILiteral' [stdout] 25-05-27 09:26:41 36 | class ASCIILiteral; [stdout] 25-05-27 09:26:41 | ^ ```
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2025-05-27 12:21:05 PDT
<
rdar://problem/152102291
>
David Kilzer (:ddkilzer)
Comment 2
2025-05-27 12:23:06 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/45955
EWS
Comment 3
2025-05-27 12:35:03 PDT
Committed
295456@main
(2540bba1c240): <
https://commits.webkit.org/295456@main
> Reviewed commits have been landed. Closing PR #45955 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug