Bug 29356 – LayoutTests/platform/win/accessibility/scroll-to-anchor.html doesn't render as text if there's no accessibilityController

• Status: RESOLVED
• Resolution: INVALID
• Component: Tools / Tests

[Dirk Pranke]

Chromium does not yet implement accessibilityController() in test_shell (chromium's version of dumpRenderTree). The test script bails out without calling dumpAsText(), which causes Chromium's test driver (run_webkit_tests) to expect there to be an image baseline, and there isn't one.

[Dirk Pranke]

Created attachment 39746 [details]
patch to handle accessibilityController not being present more gracefully

[Eric Seidel (no email)]

Comment on attachment 39746 [details]
patch to handle accessibilityController not being present more gracefully

Indent is wrong.

This makes no sense?  Why not just skip this test?  What purpose does it serve if accessibilityController is not there?

[Dirk Pranke]

Created attachment 39749 [details]
patch w/ revised indent

[Dirk Pranke]

(In reply to comment #2)
> (From update of attachment 39746 [details])
> Indent is wrong.

Fixed! Thanks.

> This makes no sense?  Why not just skip this test?  What purpose does it serve
> if accessibilityController is not there?

If we skip the test, then we're not running it at all. If we don't skip the test, we are at least insuring that we don't crash on this test. Another way of saying this is that I don't like skipping tests :)

[Darin Fisher (:fishd, Google)]

Comment on attachment 39749 [details]
patch w/ revised indent

I don't think this is the right change to make.  We should leave the test as is.

Back in chromium land, we should just implement a no-op accessibilityController
if we want to avoid skipping the test.

[Dirk Pranke]

okey doke.