Bug 29349 - Added check for MathML support to run-webkit-tests
Summary: Added check for MathML support to run-webkit-tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 29158
  Show dependency tree / graph
 
Reported: 2009-09-17 15:26 PDT by Alex Milowski
Modified: 2009-09-18 12:06 PDT (History)
1 user (show)

See Also:

Attachments
Patch supporting testing for MathML (2.19 KB, patch)
2009-09-17 15:26 PDT, Alex Milowski 		mjs: review-
Details | Formatted Diff | Diff
Updated patch with extra checks removed (2.09 KB, patch)
2009-09-17 18:25 PDT, Alex Milowski 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Milowski 2009-09-17 15:26:13 PDT 
Created attachment 39729 [details]
Patch supporting testing for MathML

Added the checks to the support libraries to check to see in MathML has been compiled.  If not, then the mathml layout tests are ignored.
Comment 1 Maciej Stachowiak 2009-09-17 18:20:03 PDT 
Comment on attachment 39729 [details]
Patch supporting testing for MathML

Why does this hardcode the MathML support values for Qt and Wx? That doesn't seem right...
Comment 2 Alex Milowski 2009-09-17 18:25:14 PDT 
Created attachment 39743 [details]
Updated patch with extra checks removed
Comment 3 Maciej Stachowiak 2009-09-17 18:43:08 PDT 
Comment on attachment 39743 [details]
Updated patch with extra checks removed

r=me
Comment 4 Eric Seidel (no email) 2009-09-18 11:44:33 PDT 
Comment on attachment 39743 [details]
Updated patch with extra checks removed

IIRC Alex is not a committer, adding cq+
Comment 5 WebKit Commit Bot 2009-09-18 12:06:23 PDT 
Comment on attachment 39743 [details]
Updated patch with extra checks removed

Clearing flags on attachment: 39743

Committed r48522: <http://trac.webkit.org/changeset/48522>
Comment 6 WebKit Commit Bot 2009-09-18 12:06:26 PDT 
All reviewed patches have been landed.  Closing bug.