Bug 29349 - Added check for MathML support to run-webkit-tests
: Added check for MathML support to run-webkit-tests
Status: RESOLVED FIXED
: WebKit
Tools / Tests
: 528+ (Nightly build)
: PC Mac OS X 10.5
: P2 Normal
Assigned To:
:
:
:
: 29158
  Show dependency treegraph
 
Reported: 2009-09-17 15:26 PST by
Modified: 2009-09-18 12:06 PST (History)


Attachments
Patch supporting testing for MathML (2.19 KB, patch)
2009-09-17 15:26 PST, Alex Milowski
mjs: review-
Review Patch | Details | Formatted Diff | Diff
Updated patch with extra checks removed (2.09 KB, patch)
2009-09-17 18:25 PST, Alex Milowski
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2009-09-17 15:26:13 PST
Created an attachment (id=39729) [details]
Patch supporting testing for MathML

Added the checks to the support libraries to check to see in MathML has been compiled.  If not, then the mathml layout tests are ignored.
------- Comment #1 From 2009-09-17 18:20:03 PST -------
(From update of attachment 39729 [details])
Why does this hardcode the MathML support values for Qt and Wx? That doesn't seem right...
------- Comment #2 From 2009-09-17 18:25:14 PST -------
Created an attachment (id=39743) [details]
Updated patch with extra checks removed
------- Comment #3 From 2009-09-17 18:43:08 PST -------
(From update of attachment 39743 [details])
r=me
------- Comment #4 From 2009-09-18 11:44:33 PST -------
(From update of attachment 39743 [details])
IIRC Alex is not a committer, adding cq+
------- Comment #5 From 2009-09-18 12:06:23 PST -------
(From update of attachment 39743 [details])
Clearing flags on attachment: 39743

Committed r48522: <http://trac.webkit.org/changeset/48522>
------- Comment #6 From 2009-09-18 12:06:26 PST -------
All reviewed patches have been landed.  Closing bug.