WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
293456
Better handling of min/max widths that depend on the containing block
https://bugs.webkit.org/show_bug.cgi?id=293456
Summary
Better handling of min/max widths that depend on the containing block
Ahmad Saleem
Reported
2025-05-22 15:47:10 PDT
Hi Team, While going through Blink's commit, I came across another failing test case uniquely in Safari / WebKit: Test Case:
https://jsfiddle.net/eqpxmjbc/
Fails on WebKit ToT (
295304@main
) but passes on Chrome Canary 138 and Firefox Nightly 140. Blink Commit:
https://chromium.googlesource.com/chromium/src.git/+/4aad5b967dc3c9405565f8a7274d2ff9c37e6405
I haven't looked whether it can be merged or not but good to track, so raising bug. Thanks!
Attachments
Test reduction
(607 bytes, text/html)
2025-05-25 07:55 PDT
,
alan
no flags
Details
Patch
(12.90 KB, patch)
2025-05-26 19:29 PDT
,
alan
no flags
Details
Formatted Diff
Diff
Patch
(13.72 KB, patch)
2025-05-27 08:31 PDT
,
alan
no flags
Details
Formatted Diff
Diff
Patch
(12.62 KB, patch)
2025-05-27 14:58 PDT
,
alan
no flags
Details
Formatted Diff
Diff
[fast-cq]Patch
(12.79 KB, patch)
2025-05-27 18:06 PDT
,
alan
no flags
Details
Formatted Diff
Diff
Show Obsolete
(3)
View All
Add attachment
proposed patch, testcase, etc.
alan
Comment 1
2025-05-25 07:55:52 PDT
Created
attachment 475370
[details]
Test reduction
alan
Comment 2
2025-05-26 19:29:42 PDT
Created
attachment 475378
[details]
Patch
alan
Comment 3
2025-05-27 08:31:00 PDT
Created
attachment 475384
[details]
Patch
Ahmad Saleem
Comment 4
2025-05-27 11:06:03 PDT
From patch, it seems that the changelog generated seems to be wrong by script: * Source/WebCore/rendering/RenderBlock.cpp: (WebCore::RenderBlock::updateBlockChildDirtyBitsBeforeLayout): * Source/WebCore/rendering/RenderBlockFlow.cpp: (WebCore::RenderBlockFlow::layoutInlineContent): * Source/WebCore/rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::computeMainAxisExtentForFlexItem): It should be `RenderObject`? I never used this old patch flow - so I might be wrong here.
alan
Comment 5
2025-05-27 14:58:38 PDT
Created
attachment 475389
[details]
Patch
alan
Comment 6
2025-05-27 14:59:02 PDT
(In reply to Ahmad Saleem from
comment #4
)
> From patch, it seems that the changelog generated seems to be wrong by > script: > > * Source/WebCore/rendering/RenderBlock.cpp: > (WebCore::RenderBlock::updateBlockChildDirtyBitsBeforeLayout): > * Source/WebCore/rendering/RenderBlockFlow.cpp: > (WebCore::RenderBlockFlow::layoutInlineContent): > * Source/WebCore/rendering/RenderFlexibleBox.cpp: > (WebCore::RenderFlexibleBox::computeMainAxisExtentForFlexItem): > > It should be `RenderObject`? I never used this old patch flow - so I might > be wrong here.
Fixed.
alan
Comment 7
2025-05-27 18:06:07 PDT
Created
attachment 475392
[details]
[fast-cq]Patch
EWS
Comment 8
2025-05-28 04:42:46 PDT
Committed
295501@main
(816d87103a2c): <
https://commits.webkit.org/295501@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 475392
[details]
.
Radar WebKit Bug Importer
Comment 9
2025-05-28 04:43:12 PDT
<
rdar://problem/152148871
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug