The test tst_QWebFrame::popupFocus() fails on slow computers because the focus is not yet set when the value is tested. QTRY_COMPARE should be used instead of QCOMPARE when the event loop is involved.
Created attachment 39722 [details] proposed patch
Comment on attachment 39722 [details] proposed patch r=me
Comment on attachment 39722 [details] proposed patch Rejecting patch 39722 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 11284 test cases. http/tests/xmlhttprequest/cross-origin-no-authorization.html -> failed Exiting early after 1 failures. 8923 tests run. 255.73s total testing time 8922 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 5 test cases (<1%) had stderr output
Comment on attachment 39722 [details] proposed patch I believe that's just a flakey test. bug 29322. Sorry for the slow feedback, the commit-queue was paused for the last 17 hours due to red builders. http://webkit-commit-queue.appspot.com/
Comment on attachment 39722 [details] proposed patch Clearing flags on attachment: 39722 Committed r48561: <http://trac.webkit.org/changeset/48561>
All reviewed patches have been landed. Closing bug.