RESOLVED FIXED 29334
Add LayoutTests to test proper security checks for the cases when prototype of top window is set to child window 
https://bugs.webkit.org/show_bug.cgi?id=29334
Summary Add LayoutTests to test proper security checks for the cases when prototype o...
anton muhin
Reported 2009-09-17 09:48:43 PDT
Adding some more Layout test which verify that fiddling with top window prototype doesn't lead to security troubles. Sorry, not ideal component---best I could think of.
Attachments
First pass (9.37 KB, patch)
2009-09-17 09:53 PDT, anton muhin 		no flags
DetailsFormatted DiffDiff
ChangeLog updated (9.45 KB, patch)
2009-09-17 09:55 PDT, anton muhin 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
anton muhin
Comment 1 2009-09-17 09:53:28 PDT
Created attachment 39699 [details] First pass
anton muhin
Comment 2 2009-09-17 09:55:37 PDT
Created attachment 39700 [details] ChangeLog updated
Adam Barth
Comment 3 2009-09-17 10:01:17 PDT
Comment on attachment 39700 [details] ChangeLog updated The names of the tests are not ideal because they don't say anything about about globals or __proto__, but I don't think that matters very much.
WebKit Commit Bot
Comment 4 2009-09-17 12:22:52 PDT
Comment on attachment 39700 [details] ChangeLog updated Rejecting patch 39700 from commit-queue. Failed to run "['git', 'svn', 'dcommit']" exit_code: 1 Committing to http://svn.webkit.org/repository/webkit/trunk ...
Eric Seidel (no email)
Comment 5 2009-09-17 12:24:59 PDT
Comment on attachment 39700 [details] ChangeLog updated You were bitten by bug 28316, which I'm working on fixing this week. Sorry. :(
WebKit Commit Bot
Comment 6 2009-09-17 12:43:56 PDT
Comment on attachment 39700 [details] ChangeLog updated Clearing flags on attachment: 39700 Committed r48484: <http://trac.webkit.org/changeset/48484>
WebKit Commit Bot
Comment 7 2009-09-17 12:44:00 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.