RESOLVED FIXED 29327
FontDescription.h includes RenderStyleConstants.h, which violates layering 
https://bugs.webkit.org/show_bug.cgi?id=29327
Summary FontDescription.h includes RenderStyleConstants.h, which violates layering
mitz
Reported 2009-09-17 00:12:32 PDT
FontDescription.h includes RenderStyleConstants.h for the FontSmoothing enum, but that constitutes a layering violation (platform code should not depend on other engine code). Patch forthcoming.
Attachments
Move the FontSmoothing enum into platform (13.17 KB, patch)
2009-09-17 00:23 PDT, mitz 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2009-09-17 00:23:04 PDT
Created attachment 39682 [details] Move the FontSmoothing enum into platform
Simon Fraser (smfr)
Comment 2 2009-09-17 09:23:22 PDT
Comment on attachment 39682 [details] Move the FontSmoothing enum into platform r=me but you should check to see if other build system need fixing.
mitz
Comment 3 2009-09-17 10:34:15 PDT
Fixed in <http://trac.webkit.org/projects/webkit/changeset/48474>
Note You need to log in before you can comment on or make changes to this bug.