Bug 29320 - JS callback objects should store the global object
Summary: JS callback objects should store the global object
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-16 16:37 PDT by Sam Weinig
Modified: 2009-09-18 11:57 PDT (History)
1 user (show)

See Also:

Attachments
patch (41.75 KB, patch)
2009-09-16 20:00 PDT, Sam Weinig 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2009-09-16 16:37:04 PDT 
JS callback objects (position, database) should store the global object instead of the frame.
Comment 1 Sam Weinig 2009-09-16 20:00:13 PDT 
Created attachment 39678 [details]
patch

This patch changes the callbacks to store a global object instead of the Frame and removes some unnecessary script()->isEnabled() checks. I will do a follow up which changes the global object to use the 'current' one.
Comment 2 Anders Carlsson 2009-09-16 20:11:39 PDT 
Comment on attachment 39678 [details]
patch

r=me
Comment 3 Sam Weinig 2009-09-16 20:43:05 PDT 
Landed in r48453 with slight tweaks.
Comment 4 Adam Barth 2009-09-17 13:29:34 PDT 
Why exec->dynamicGlobalObject() some times and exec->lexicalGlobalObject() other times?  Also, this patch doesn't have tests...
Comment 5 Alexey Proskuryakov 2009-09-18 11:57:27 PDT 
Yeah, this definitely needs tests...