WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
293190
HashTable doesn't need `ShouldValidateKey` as template parameter for the whole class
https://bugs.webkit.org/show_bug.cgi?id=293190
Summary
HashTable doesn't need `ShouldValidateKey` as template parameter for the whol...
Chris Dumez
Reported
2025-05-17 14:42:05 PDT
HashTable doesn't need `ShouldValidateKey` as template parameter for the whole class. Instead, only add this template parameter for HashTable functions that actually need it. This reduces unnecessary code duplication, reduces binary size in WebCore by 1MB and avoids redundant key validations since we can now be more fine-grained.
Attachments
Add attachment
proposed patch, testcase, etc.
Chris Dumez
Comment 1
2025-05-17 14:44:09 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/45555
EWS
Comment 2
2025-05-18 11:06:10 PDT
Committed
295078@main
(a8416d2c6a3b): <
https://commits.webkit.org/295078@main
> Reviewed commits have been landed. Closing PR #45555 and removing active labels.
Radar WebKit Bug Importer
Comment 3
2025-05-18 11:07:28 PDT
<
rdar://problem/151562991
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug