Bug 29319 – Reorganizing helper functions in htmlediting.h

• Status: RESOLVED
• Resolution: FIXED
• Component: HTML Editing

[Enrica Casucci]

Reorganizing helper functions in htmlediting.h to group them by type of object they return/operate upon.

[Enrica Casucci]

Created attachment 39665 [details]
Patch

[Enrica Casucci]

Created attachment 39666 [details]
Patch2

[Eric Seidel (no email)]

Comment on attachment 39666 [details]
Patch2

Welcome to WebKit! :)

Seems there is an extra newline after isAtUnsplittableElement.

I wonder why this doesn't return HTMLElement:
118202 PassRefPtr<Element> createTabSpanElement(Document*);
(You shouldn't change it now, just noting.)

Space after a period?
 15         (WebCore::isAtUnsplittableElement): added.The code has been taken from IndentOutdentCommand.

This looks fine though.  Either you can get someone to commit this for you with modifications, or you can post a new patch with the spacing fixed and the commit queue could take care of this.  Your call.

[Eric Seidel (no email)]

15         (WebCore::isAtUnsplittableElement): added.The code has been taken
from IndentOutdentCommand.

Should also probably be "The code was taken from IndentOutdentCommand.cpp".  "has been" sounds strange to my ears.

[Enrica Casucci]

Created attachment 39671 [details]
New patch including feedback from review

[Eric Seidel (no email)]

Comment on attachment 39671 [details]
New patch including feedback from review

Well, again welcome.  Congrats on your first patch.

LGTM.

[WebKit Commit Bot]

Comment on attachment 39671 [details]
New patch including feedback from review

Rejecting patch 39671 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1
Running build-dumprendertree
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 11266 test cases.
http/tests/xmlhttprequest/cross-origin-authorization.html -> failed

Exiting early after 1 failures.  8903 tests run.
278.70s total testing time

8902 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
6 test cases (<1%) had stderr output

[Eric Seidel (no email)]

Comment on attachment 39671 [details]
New patch including feedback from review

I'm very sad this was your first experience with the commit-queue.  It looks like you hit a flakey test.  I've filed bug 29322 about the flakey test.

[WebKit Commit Bot]

Committed r48448: <http://trac.webkit.org/changeset/48448>