RESOLVED FIXED 29318
Update contributing.html to mention recently added tools. 
https://bugs.webkit.org/show_bug.cgi?id=29318
Summary Update contributing.html to mention recently added tools.
Eric Seidel (no email)
Reported 2009-09-16 15:47:00 PDT
Update contributing.html to mention recently added tools. CC'ing darin as he's often edited this file in the past.
Attachments
Patch v1 (6.32 KB, patch)
2009-09-16 15:48 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2009-09-16 15:48:29 PDT
Created attachment 39664 [details] Patch v1
Darin Adler
Comment 2 2009-09-16 22:33:47 PDT
Comment on attachment 39664 [details] Patch v1 > - <li>Upload the patch for review. In Bugzilla, be sure to set the <tt>review:?</tt> flag.</li> > + <li>Upload the patch for review. In Bugzilla, be sure to mark your file as a patch and set the <tt>review:?</tt> flag.</li> I think this could be slightly more explicit; it may not be obvious there is a check box labeled "patch" they have to check. But I don't have better wording to suggest.
Eric Seidel (no email)
Comment 3 2009-09-16 23:53:53 PDT
Comment on attachment 39664 [details] Patch v1 Agreed. We could further improve the patch checkbox wording. Ideally we could just get rid of that checkbox all together. :) I think for now I'll commit this as is and we can iterate from here. Thanks for the review! I'll mark this cq+. The queue is off for the moment as Mark has been performing builder maintenance this evening. This will land tomorrow morning when I turn the queue back on.
WebKit Commit Bot
Comment 4 2009-09-17 13:07:20 PDT
Comment on attachment 39664 [details] Patch v1 Clearing flags on attachment: 39664 Committed r48488: <http://trac.webkit.org/changeset/48488>
WebKit Commit Bot
Comment 5 2009-09-17 13:07:25 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.