Bug 29318 - Update contributing.html to mention recently added tools.
Summary: Update contributing.html to mention recently added tools.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Website (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-16 15:47 PDT by Eric Seidel (no email)
Modified: 2009-09-17 13:07 PDT (History)
3 users (show)

See Also:


Attachments
Patch v1 (6.32 KB, patch)
2009-09-16 15:48 PDT, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2009-09-16 15:47:00 PDT
Update contributing.html to mention recently added tools.

CC'ing darin as he's often edited this file in the past.
Comment 1 Eric Seidel (no email) 2009-09-16 15:48:29 PDT
Created attachment 39664 [details]
Patch v1
Comment 2 Darin Adler 2009-09-16 22:33:47 PDT
Comment on attachment 39664 [details]
Patch v1

> -    <li>Upload the patch for review. In Bugzilla, be sure to set the <tt>review:?</tt> flag.</li>
> +    <li>Upload the patch for review. In Bugzilla, be sure to mark your file as a patch and set the <tt>review:?</tt> flag.</li>

I think this could be slightly more explicit; it may not be obvious there is a check box labeled "patch" they have to check. But I don't have better wording to suggest.
Comment 3 Eric Seidel (no email) 2009-09-16 23:53:53 PDT
Comment on attachment 39664 [details]
Patch v1

Agreed.  We could further improve the patch checkbox wording.  Ideally we could just get rid of that checkbox all together. :)

I think for now I'll commit this as is and we can iterate from here.  Thanks for the review!

I'll mark this cq+.  The queue is off for the moment as Mark has been performing builder maintenance this evening.  This will land tomorrow morning when I turn the queue back on.
Comment 4 WebKit Commit Bot 2009-09-17 13:07:20 PDT
Comment on attachment 39664 [details]
Patch v1

Clearing flags on attachment: 39664

Committed r48488: <http://trac.webkit.org/changeset/48488>
Comment 5 WebKit Commit Bot 2009-09-17 13:07:25 PDT
All reviewed patches have been landed.  Closing bug.