Bug 29311 - webkit-patch commit-queue should notice if it breaks builders (and roll out its own changes)
Summary: webkit-patch commit-queue should notice if it breaks builders (and roll out i...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Eric Seidel (no email)
Depends on:
Reported: 2009-09-16 13:54 PDT by Eric Seidel (no email)
Modified: 2010-03-29 13:40 PDT (History)
1 user (show)

See Also:

Patch (9.36 KB, patch)
2010-03-26 16:46 PDT, Eric Seidel (no email)
abarth: review+
eric: commit-queue+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2009-09-16 13:54:01 PDT
bugzilla-tool should notice if it breaks builders

bugzilla-tool could remember which commits it made, and looking at the buildbot output determine if one of its commits broke a builder, and if so email the responsible parties.

It might be easier to make buildbot smarter about who it emails instead.

With such information it could also just roll out its patch instead of emailing people, but that's a bit scarier at the moment since "bugzilla-tool rollout" is not quite idiot proof yet.
Comment 1 Eric Seidel (no email) 2010-03-26 16:46:53 PDT
Created attachment 51796 [details]
Comment 2 Adam Barth 2010-03-29 09:58:58 PDT
Comment on attachment 51796 [details]

Ok, but we should have some facility for closing these bugs automatically when the tree goes green.
Comment 3 Eric Seidel (no email) 2010-03-29 10:11:26 PDT
OK.  I'll do that in a follow-up patch.  Be advised, since you're currently running the Sheriff Bot, I've not live-tested these changes and there may be a typo which will require a follow-up commit.
Comment 4 Eric Seidel (no email) 2010-03-29 11:39:42 PDT
Attachment 51796 [details] was posted by a committer and has review+, assigning to Eric Seidel for commit.
Comment 5 Eric Seidel (no email) 2010-03-29 13:40:30 PDT
Committed r56737: <http://trac.webkit.org/changeset/56737>