WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
292956
Remove unnecessary RefPtr in BackForwardCache
https://bugs.webkit.org/show_bug.cgi?id=292956
Summary
Remove unnecessary RefPtr in BackForwardCache
Charlie Wolfe
Reported
2025-05-13 14:04:51 PDT
Crash data indicates a WebKitLegacy crash occurs after creating a RefPtr to LocalFrame in `BackForwardCache::markPagesForContentsSizeChanged`. The RefPtr introduced in
288208@main
is unnecessary, as it is only used for address comparison. We should just remove it.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2025-05-13 14:05:00 PDT
<
rdar://problem/151252906
>
Charlie Wolfe
Comment 2
2025-05-13 14:05:42 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/45333
EWS
Comment 3
2025-05-13 14:10:27 PDT
Committed
294865@main
(1829739d63b0): <
https://commits.webkit.org/294865@main
> Reviewed commits have been landed. Closing PR #45333 and removing active labels.
EWS
Comment 4
2025-05-14 10:42:19 PDT
Committed
289651.512@safari-7621-branch
(1551338abcd1): <
https://commits.webkit.org/289651.512@safari-7621-branch
> Reviewed commits have been landed. Closing PR #3094 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug