Bug 292822 – [button-layout] display: flex cause text not being centered in input type button

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Ahmad Saleem]

Hi Team,

While trying to find out WebKit / Safari specific failures on WPT, I noticed that we are failing this test case:

WPT Test Case: https://wpt.fyi/results/html/rendering/widgets/button-layout/anonymous-button-content-box.html?label=experimental&label=master&aligned

WPT Live Link: http://wpt.live/html/rendering/widgets/button-layout/anonymous-button-content-box.html

Reduction: https://jsfiddle.net/5fyhbsz9/

^ Removing `float: left' makes it match other browsers. Hence I named it like that but could be any other reason as well. Safari differ from Firefox and Chrome here.

Just raising, so we can track it. If it is dupe to already raised bug, we can mark it duplicate as well.

Thanks!

[alan]

>^ Removing `float: left' makes it match other browsers.
really? I must be missing something here as 'float: left' should not have any impact on the content inside, and does not according to my local testing, while removing 'display: flex' fixes the input, which makes a lot more sense as display property drives content layout here.

[Ahmad Saleem]

(In reply to zalan from comment #1)
> >^ Removing `float: left' makes it match other browsers.
> really? I must be missing something here as 'float: left' should not have
> any impact on the content inside, and does not according to my local
> testing, while removing 'display: flex' fixes the input, which makes a lot
> more sense as display property drives content layout here.

Ignore me - I think I might have mixed it with another different tab.

[alan]

Created attachment 475186 [details]
Patch

[alan]

Let's see what breaks.

[alan]

no breaks at all. amazing.

[alan]

Created attachment 475187 [details]
Patch

[alan]

Created attachment 475196 [details]
Patch

[Antti Koivisto]

Comment on attachment 475196 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=475196&action=review

> COMMIT_MESSAGE:1
> +[button-layout] dispaly:flex cause text not being entered in input type button 

spelling dispaly

[alan]

Created attachment 475197 [details]
[fast-cq]Patch

[EWS]

Committed 294785@main (a5b74fd0d393): <https://commits.webkit.org/294785@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 475197 [details].

[Radar WebKit Bug Importer]

<rdar://problem/151148821>