There are some build errors with ARM_THUMB2 JIT on Linux platforms.
Created attachment 39604 [details] Build fix to enable ARM_THUMB2 on Linux This patch fixes the ARM_THUMB2 JIT on Linux
Wasn't there a separate bug about this exact issue already?
Comment on attachment 39604 [details] Build fix to enable ARM_THUMB2 on Linux All looks good to me.
Comment on attachment 39604 [details] Build fix to enable ARM_THUMB2 on Linux I think this ChangeLog might confuse svn-apply. Please post a new diff.
> I think this ChangeLog might confuse svn-apply. Well, this bug depends on bug 29122. So the ChangeLog difference is the less important thing which could break the svn-apply. I also said that to Gavin after Comment #2. Anyway I am going post a new patch where the ChangeLog will look good.
Created attachment 39680 [details] Build fix to enable ARM_THUMB2 on Linux (v2) ChangeLog has been updated. The patch still depends on bug 29122.
Sending JavaScriptCore/ChangeLog Sending JavaScriptCore/jit/ExecutableAllocator.h Sending JavaScriptCore/jit/JITStubs.cpp Sending JavaScriptCore/wtf/Platform.h Transmitting file data .... Committed revision 48527. Hey Loki, I've landed the build fixes, but I've reverted a couple of the changes to Platform.h (rs=ggaren) – I don't think this can be enabled by default right now, since the THUMB2 JIT is still not yet complete. cheers, G.
Comment on attachment 39680 [details] Build fix to enable ARM_THUMB2 on Linux (v2) I don't know what the status of this bug is, but since it's closed it should not have a r? patch on it.
Gah, sorry about that eric, Should have r+'ed this, and should have closed it. Fixed in: http://trac.webkit.org/changeset/48527 Sorry, my bad!
No problem at all. :) Just cleaning out the review queue.