RESOLVED FIXED 29273
Build fix for ARM_THUMB2 on Linux 
https://bugs.webkit.org/show_bug.cgi?id=29273
Summary Build fix for ARM_THUMB2 on Linux
Gabor Loki
Reported 2009-09-15 09:05:35 PDT
There are some build errors with ARM_THUMB2 JIT on Linux platforms.
Attachments
Build fix to enable ARM_THUMB2 on Linux (6.78 KB, patch)
2009-09-15 09:07 PDT, Gabor Loki 		eric: review-
DetailsFormatted DiffDiff
Build fix to enable ARM_THUMB2 on Linux (v2) (6.69 KB, patch)
2009-09-16 21:59 PDT, Gabor Loki 		barraclough: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gabor Loki
Comment 1 2009-09-15 09:07:04 PDT
Created attachment 39604 [details] Build fix to enable ARM_THUMB2 on Linux This patch fixes the ARM_THUMB2 JIT on Linux
Eric Seidel (no email)
Comment 2 2009-09-15 18:06:59 PDT
Wasn't there a separate bug about this exact issue already?
Gavin Barraclough
Comment 3 2009-09-16 12:11:30 PDT
Comment on attachment 39604 [details] Build fix to enable ARM_THUMB2 on Linux All looks good to me.
Eric Seidel (no email)
Comment 4 2009-09-16 14:45:01 PDT
Comment on attachment 39604 [details] Build fix to enable ARM_THUMB2 on Linux I think this ChangeLog might confuse svn-apply. Please post a new diff.
Gabor Loki
Comment 5 2009-09-16 21:17:41 PDT
> I think this ChangeLog might confuse svn-apply. Well, this bug depends on bug 29122. So the ChangeLog difference is the less important thing which could break the svn-apply. I also said that to Gavin after Comment #2. Anyway I am going post a new patch where the ChangeLog will look good.
Gabor Loki
Comment 6 2009-09-16 21:59:57 PDT
Created attachment 39680 [details] Build fix to enable ARM_THUMB2 on Linux (v2) ChangeLog has been updated. The patch still depends on bug 29122.
Gavin Barraclough
Comment 7 2009-09-18 13:37:38 PDT
Sending JavaScriptCore/ChangeLog Sending JavaScriptCore/jit/ExecutableAllocator.h Sending JavaScriptCore/jit/JITStubs.cpp Sending JavaScriptCore/wtf/Platform.h Transmitting file data .... Committed revision 48527. Hey Loki, I've landed the build fixes, but I've reverted a couple of the changes to Platform.h (rs=ggaren) – I don't think this can be enabled by default right now, since the THUMB2 JIT is still not yet complete. cheers, G.
Eric Seidel (no email)
Comment 8 2009-09-22 14:29:58 PDT
Comment on attachment 39680 [details] Build fix to enable ARM_THUMB2 on Linux (v2) I don't know what the status of this bug is, but since it's closed it should not have a r? patch on it.
Gavin Barraclough
Comment 9 2009-09-22 14:38:36 PDT
Gah, sorry about that eric, Should have r+'ed this, and should have closed it. Fixed in: http://trac.webkit.org/changeset/48527 Sorry, my bad!
Eric Seidel (no email)
Comment 10 2009-09-22 14:47:47 PDT
No problem at all. :) Just cleaning out the review queue.
Note You need to log in before you can comment on or make changes to this bug.