WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
29270
[Qt] WebCore/bindings/js/JSDOMWindowCustom.cpp fails to compile
https://bugs.webkit.org/show_bug.cgi?id=29270
Summary
[Qt] WebCore/bindings/js/JSDOMWindowCustom.cpp fails to compile
Bernhard Rosenkraenzer
Reported
2009-09-15 05:27:50 PDT
g++ -c [flags trimmed for sake of readability] -DENABLE_3D_RENDERING=1 -DENABLE_FILTERS=1 -DENABLE_GEOLOCATION=1 -DENABLE_SVG_DOM_OBJC_BINDINGS=1 -DENABLE_WEB_SOCKETS=1 -DENABLE_WML=1 -DENABLE_XSLT=1 -DBUILDING_QT__=1 -DUSE_SYSTEM_MALLOC -DNDEBUG -DQT_MAKEDLL -DHAVE_STDINT_H -DBUILD_WEBKIT -DENABLE_JAVASCRIPT_DEBUGGER=1 -DENABLE_DATABASE=1 -DENABLE_EVENTSOURCE=1 -DENABLE_OFFLINE_WEB_APPLICATIONS=1 -DENABLE_DOM_STORAGE=1 -DENABLE_ICONDATABASE=1 -DENABLE_CHANNEL_MESSAGING=1 -DENABLE_SQLITE=1 -DENABLE_DASHBOARD_SUPPORT=0 -DENABLE_XPATH=1 -DENABLE_WCSS=0 -DENABLE_SHARED_WORKERS=1 -DENABLE_WORKERS=1 -DENABLE_XHTMLMP=0 -DENABLE_DATAGRID=1 -DENABLE_SVG=1 -DENABLE_SVG_FONTS=1 -DENABLE_SVG_FOREIGN_OBJECT=1 -DENABLE_SVG_ANIMATION=1 -DENABLE_SVG_AS_IMAGE=1 -DENABLE_SVG_USE=1 -DENABLE_RUBY=1 -DENABLE_VIDEO=1 -DENABLE_DATALIST=1 -DENABLE_NETSCAPE_PLUGIN_API=1 -DWTF_USE_JAVASCRIPTCORE_BINDINGS=1 -DWTF_CHANGES=1 -DBUILDING_QT__ -DBUILDING_JavaScriptCore -DBUILDING_WTF -DENABLE_PLUGIN_PACKAGE_SIMPLE_HASH=1 -DXP_UNIX -DQT_NO_DEBUG -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_CORE_LIB -DQT_SHARED [loads of -I paths trimmed for sake of readability] -o obj/release/JSDOMWindowCustom.o ../../../WebCore/bindings/js/JSDOMWindowCustom.cpp ../../../WebCore/bindings/js/JSDOMWindowCustom.cpp:713: error: no 'JSC::JSValue WebCore::JSDOMWindow::webSocket(JSC::ExecState*) const' member function declared in class 'WebCore::JSDOMWindow' make[1]: *** [obj/release/JSDOMWindowCustom.o] Error 1
Attachments
Update Qt build system for Web Socket
(10.29 KB, patch)
2009-09-18 03:12 PDT
,
Fumitoshi Ukai
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Fumitoshi Ukai
Comment 1
2009-09-18 03:05:27 PDT
I tried "build-webkit --qt" and found other issue (
bug 29362
). With patch of
bug 29362
, I could successfully build webkit for qt. Anyway, just enabling ENABLE_WEB_SOCKET=1, build fails as reported. I'll send a patch to fix it.
Fumitoshi Ukai
Comment 2
2009-09-18 03:12:27 PDT
Created
attachment 39755
[details]
Update Qt build system for Web Socket --- 5 files changed, 233 insertions(+), 2 deletions(-)
Simon Hausmann
Comment 3
2009-09-18 07:22:18 PDT
Comment on
attachment 39755
[details]
Update Qt build system for Web Socket r=me. Thanks for fixing the Qt build! Much appreciated :)
WebKit Commit Bot
Comment 4
2009-09-18 07:48:55 PDT
Comment on
attachment 39755
[details]
Update Qt build system for Web Socket Rejecting patch 39755 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 11274 test cases. http/tests/loading/basic-credentials-sent-automatically.html -> failed Exiting early after 1 failures. 8406 tests run. 190.88s total testing time 8405 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 4 test cases (<1%) had stderr output
Eric Seidel (no email)
Comment 5
2009-09-18 11:42:46 PDT
Comment on
attachment 39755
[details]
Update Qt build system for Web Socket http/tests/loading/basic-credentials-sent-automatically.html -> failed appears unrelated.
WebKit Commit Bot
Comment 6
2009-09-18 11:57:22 PDT
Comment on
attachment 39755
[details]
Update Qt build system for Web Socket Clearing flags on attachment: 39755 Committed
r48520
: <
http://trac.webkit.org/changeset/48520
>
WebKit Commit Bot
Comment 7
2009-09-18 11:57:29 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug