RESOLVED INVALID 29267
Need a way to replace a plug-in with a substitute image 
https://bugs.webkit.org/show_bug.cgi?id=29267
Summary Need a way to replace a plug-in with a substitute image
Jon Honeycutt
Reported 2009-09-15 00:11:21 PDT
Created attachment 39588 [details] Patch We would like to have a way to replace a plug-in with a substitute image.
Attachments
Patch (19.35 KB, patch)
2009-09-15 00:11 PDT, Jon Honeycutt 		jhoneycutt: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2009-09-15 07:52:21 PDT
Comment on attachment 39588 [details] Patch > diff --git a/WebCore/rendering/RenderObject.h b/WebCore/rendering/RenderObject.h > index 0a3473c..c4fae6f 100644 > --- a/WebCore/rendering/RenderObject.h > +++ b/WebCore/rendering/RenderObject.h > @@ -738,6 +738,8 @@ public: > return outlineBoundsForRepaint(0); > } > > + virtual bool showSubstituteImage(PassRefPtr<Image>) { return false; } This seems wrong. Why does RenderObject need to expose this? Also, it should be a const method.
Jon Honeycutt
Comment 2 2009-09-15 16:18:04 PDT
(In reply to comment #1) > (From update of attachment 39588 [details]) > > > > + virtual bool showSubstituteImage(PassRefPtr<Image>) { return false; } > > This seems wrong. Why does RenderObject need to expose this? Also, it should be > a const method. Well, RenderWidget is the only class that overrides this, but I think it's better to have this on RenderObject and let subclasses override it than to have WebKit's DOMElement be aware of the different RenderObject subclasses.
Simon Fraser (smfr)
Comment 3 2009-09-15 16:25:54 PDT
But showSubstituteImage() doesn't make sense for most RenderObjects.
Jon Honeycutt
Comment 4 2009-10-02 20:00:14 PDT
Obsoleted by r49060.
Note You need to log in before you can comment on or make changes to this bug.