RESOLVED INVALID 29257
Chromium needs to be able to inject its own storage event handler into StorageArea 
https://bugs.webkit.org/show_bug.cgi?id=29257
Summary Chromium needs to be able to inject its own storage event handler into Storag...
Jeremy Orlow
Reported 2009-09-14 15:01:09 PDT
Chromium needs to be able to inject its own storage event handler into StorageAreaImpl. This is because the process the StorageAreaImpl runs in is not the same process that the events need to be dispatched to.
Attachments
Patch v1 (41.58 KB, patch)
2009-09-14 15:10 PDT, Jeremy Orlow 		no flags
DetailsFormatted DiffDiff
Patch v1 (41.81 KB, patch)
2009-09-15 16:42 PDT, Jeremy Orlow 		no flags
DetailsFormatted DiffDiff
Patch v1 (44.77 KB, patch)
2009-09-21 14:40 PDT, Jeremy Orlow 		fishd: review+
jorlow: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Jeremy Orlow
Comment 1 2009-09-14 15:10:09 PDT
Created attachment 39575 [details] Patch v1
Darin Fisher (:fishd, Google)
Comment 2 2009-09-15 16:31:32 PDT
Comment on attachment 39575 [details] Patch v1 > Index: WebCore/page/DOMWindow.cpp ... > + RefPtr<StorageArea> storageArea = page->group().localStorage()->storageArea(document->securityOrigin(), new StorageEventDispatcherImpl); I think it is generally better to use the Foo::create() pattern that returns a PassRefPtr instead of passing a raw pointer. That way the ownership exchange is more clearly documented and enforced by the code. > Index: WebCore/storage/StorageEventDispatcher.h > +#include "PlatformString.h" > +#include "StorageArea.h" > + > +#include <wtf/RefCounted.h> nit: no new line after StorageArea.h Otherwise, LG
Jeremy Orlow
Comment 3 2009-09-15 16:42:23 PDT
Created attachment 39622 [details] Patch v1
Jeremy Orlow
Comment 4 2009-09-21 14:40:41 PDT
Created attachment 39879 [details] Patch v1
Jeremy Orlow
Comment 5 2009-09-21 14:47:27 PDT
Fishd: Ugh....I accidentally re-uploaded which cleared the r+. :-( Sorry.
Jeremy Orlow
Comment 6 2009-09-24 18:22:12 PDT
https://bugs.webkit.org/show_bug.cgi?id=29655 is a better way to solve this.
Note You need to log in before you can comment on or make changes to this bug.