Bug 29246 - [Qt] State of navigation buttons aren't updated
Summary: [Qt] State of navigation buttons aren't updated
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Linux
: P2 Normal
Assignee: Nobody
Keywords: Qt
Depends on:
Reported: 2009-09-14 09:45 PDT by Jędrzej Nowacki
Modified: 2009-09-23 17:33 PDT (History)
1 user (show)

See Also:

Proposed path (2.63 KB, patch)
2009-09-14 09:48 PDT, Jędrzej Nowacki
eric: review-
eric: commit-queue-
Details | Formatted Diff | Diff
Proposed path v2 (4.70 KB, patch)
2009-09-23 02:54 PDT, Jędrzej Nowacki
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jędrzej Nowacki 2009-09-14 09:45:08 PDT
If state QWebHistory object change, update action on some buttons (back, forward...) should be triggered.

For example after call QWebHistory::clear() goBack and goForward buttons should be disabled.
Comment 1 Jędrzej Nowacki 2009-09-14 09:48:51 PDT
Created attachment 39548 [details]
Proposed path

Path change clear() and restoreState() methods
Comment 2 Eric Seidel (no email) 2009-09-22 14:36:52 PDT
Comment on attachment 39548 [details]
Proposed path

//update navi buttons

Comments should be proper english sentences, starting with a capital ending with a period.
Also, I believe the style guide asks for a space after the //.

Regarding the rest of the change, I have no comment.  Although ideally it should have a test if that's possible, or an explanation in the ChangeLog of why a test is impossible/impractical.
Comment 3 Jędrzej Nowacki 2009-09-23 02:54:26 PDT
Created attachment 39984 [details]
Proposed path v2

Comments were removed.
Autotests were developed.
Comment 4 Simon Hausmann 2009-09-23 14:44:02 PDT
Comment on attachment 39984 [details]
Proposed path v2

r=me. Thanks.
Comment 5 WebKit Commit Bot 2009-09-23 17:33:18 PDT
Comment on attachment 39984 [details]
Proposed path v2

Clearing flags on attachment: 39984

Committed r48688: <http://trac.webkit.org/changeset/48688>
Comment 6 WebKit Commit Bot 2009-09-23 17:33:23 PDT
All reviewed patches have been landed.  Closing bug.