A few things in CodeGenerator.pm can be cleaned up: * The ability to return multiple .idl files from ScanDirectory isn't needed. * File::Find can be used instead of ScanDirectory. * FindParentsRecursively can be done away with; this information can be collected while in AddMethodsConstantsAndAttributesFromParentClasses. * The recursion over ancestor interfaces in AddMethodsConstantsAndAttributesFromParentClasses and GetMethodsAndAttributesFromParentClasses can be factored out. * The searches for and parsing of .idl files can be factored out.
Created attachment 39533 [details] Patch v1 Patch that simplifies CodeGenerator.pm as above.
I've tested that generated IDL files for all four binding targets are unchanged after this patch, btw.
Comment on attachment 39533 [details] Patch v1 This is mostly a rubber stamp. But the change looks good as far as I can tell. I'm *so glad* to see someone working on this again. :) I'd still love to see us re-write this in python with a real parser (instead of regexps), but this it's good to see cleanup!
Comment on attachment 39533 [details] Patch v1 Clearing flags on attachment: 39533 Committed r48356: <http://trac.webkit.org/changeset/48356>
All reviewed patches have been landed. Closing bug.
(In reply to comment #3) > This is mostly a rubber stamp. You're trusting. :-) > But the change looks good as far as I can tell. I'm *so glad* to see someone > working on this again. :) I'd still love to see us re-write this in python > with a real parser (instead of regexps), but this it's good to see cleanup! Is there consensus that scripts should be rewritten in Python? It seems most of the scripts in WebKitTools/Scripts/ are Perl.
(In reply to comment #6) > > But the change looks good as far as I can tell. I'm *so glad* to see someone > > working on this again. :) I'd still love to see us re-write this in python > > with a real parser (instead of regexps), but this it's good to see cleanup! > > Is there consensus that scripts should be rewritten in Python? It seems most > of the scripts in WebKitTools/Scripts/ are Perl. No. :) I don't think there is consensus about language choice. There is consensus that these scripts need love however. Most (all?) of the new scripting in WebKit has been done in python. But that's because much of the recent scripting has come from me or Googlers where python very much the standard language.