Bug 292342 – [repaint] Changing text-decoration-color on the block has no affect on inline content when it is completely wrapped inside an inline box

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[alan]

ssia

[alan]

Created attachment 475096 [details]
Patch

[alan]

Created attachment 475097 [details]
Patch

[Antti Koivisto]

Comment on attachment 475097 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=475097&action=review

> Source/WebCore/rendering/RenderElement.cpp:350
> +    for (auto& child : childrenOfType<RenderObject>(renderer)) {
> +        if (auto* textRenderer = dynamicDowncast<RenderText>(child); textRenderer && !textRenderer->containsOnlyCollapsibleWhitespace())
> +            return true;
> +        if (auto* inlineBoxRenderer = dynamicDowncast<RenderInline>(child); inlineBoxRenderer && hasNonWhitespaceTextContent(*inlineBoxRenderer))
> +            return true;
> +    }

Could this use InlineWalker instead of recursing?

[alan]

InlineWalker, yes please!

[alan]

Created attachment 475104 [details]
[fast-cq]Patch

[EWS]

Commit message contains (OOPS!) and no valid reviewer found, blocking PR #None. Details: [Build #2318](https://ews-build.webkit.org/#/builders/27/builds/2318)

[alan]

Created attachment 475108 [details]
[fast-cq]Patch

[EWS]

Committed 294403@main (005636013267): <https://commits.webkit.org/294403@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 475108 [details].

[Radar WebKit Bug Importer]

<rdar://problem/150483487>