Bug 29224 - FrameLoadType and WebFrameLoadType conversion broken
Summary: FrameLoadType and WebFrameLoadType conversion broken
Status: UNCONFIRMED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: All OS X 10.6
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-12 14:29 PDT by Aaron Golden
Modified: 2009-09-13 22:59 PDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Aaron Golden 2009-09-12 14:29:16 PDT
FrameLoadType and WebFrameLoadType are enumerated differently, but there is at least one C-cast between the two types, -[WebFrame _loadType] is implemented as:

- (WebFrameLoadType)_loadType
{
    return (WebFrameLoadType)_private->coreFrame->loader()->loadType();
}

and the types are:

enum FrameLoadType {
    FrameLoadTypeStandard,
    FrameLoadTypeBack,
    FrameLoadTypeForward,
    FrameLoadTypeIndexedBackForward, // a multi-item hop in the backforward list
    FrameLoadTypeReload,
    FrameLoadTypeSame,               // user loads same URL again (but not reload button)
    FrameLoadTypeRedirectWithLockedBackForwardList, // FIXME: Merge "lockBackForwardList", "lockHistory", "quickRedirect" and "clientRedirect" into a single concept of redirect.
    FrameLoadTypeReplace,
    FrameLoadTypeReloadFromOrigin
};

typedef enum {
    WebFrameLoadTypeStandard,
    WebFrameLoadTypeBack,
    WebFrameLoadTypeForward,
    WebFrameLoadTypeIndexedBackForward, // a multi-item hop in the backforward list
    WebFrameLoadTypeReload,
    WebFrameLoadTypeReloadAllowingStaleData,
    WebFrameLoadTypeSame,               // user loads same URL again (but not reload button)
    WebFrameLoadTypeInternal,           // maps to WebCore::FrameLoadTypeRedirectWithLockedBackForwardList
    WebFrameLoadTypeReplace,
    WebFrameLoadTypeReloadFromOrigin,
    WebFrameLoadTypeBackWMLDeckNotAccessible
} WebFrameLoadType;