WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
292177
[clang][glib] Unreviewed revert of LIFETIME_BOUND in GRefPtr.get()
https://bugs.webkit.org/show_bug.cgi?id=292177
Summary
[clang][glib] Unreviewed revert of LIFETIME_BOUND in GRefPtr.get()
Alicia Boya García
Reported
2025-04-28 03:35:01 PDT
LIFETIME_BOUND was added to GRefPtr.get() in
https://github.com/WebKit/WebKit/pull/44370
While it still makes sense to have that annotation, a couple build errors due to false positives not caught in testing in `Source/JavaScriptCore/API/glib/JSCContext.cpp` and `Source/WebKit/WPEPlatform/wpe/WPESettings.cpp` have been identified, making builds fail in clang. This patch temporarily removes the LIFETIME_BOUND annotation of GRefPtr.get() to make the builds work again and to buy some time to analyze the errors in more detail and how they should be fixed. * Source/WTF/wtf/glib/GRefPtr.h: (WTF::GRefPtr::get const):
Attachments
Add attachment
proposed patch, testcase, etc.
Alicia Boya García
Comment 1
2025-04-28 03:35:40 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/44595
EWS
Comment 2
2025-04-28 03:38:11 PDT
Committed
294179@main
(79fc015c2885): <
https://commits.webkit.org/294179@main
> Reviewed commits have been landed. Closing PR #44595 and removing active labels.
Michael Catanzaro
Comment 3
2025-04-28 08:43:19 PDT
***
Bug 292097
has been marked as a duplicate of this bug. ***
Michael Catanzaro
Comment 4
2025-04-28 08:48:25 PDT
Maybe we just won't be able to do this.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug