Bug 29207 - Add checks for using WebCore JS context on secondary threads
Summary: Add checks for using WebCore JS context on secondary threads
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-11 13:33 PDT by Alexey Proskuryakov
Modified: 2009-09-11 14:38 PDT (History)
0 users

See Also:


Attachments
proposed patch (3.54 KB, patch)
2009-09-11 13:36 PDT, Alexey Proskuryakov
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2009-09-11 13:33:13 PDT
WebCore JavaScript context can never be used on secondary threads, because any such use can cause GC to happen, and thus a lot of DOM code to run on this thread. We need some assertions to more easily catch such conditions with debug builds.
Comment 1 Alexey Proskuryakov 2009-09-11 13:36:51 PDT
Created attachment 39473 [details]
proposed patch
Comment 2 Geoffrey Garen 2009-09-11 14:01:50 PDT
Comment on attachment 39473 [details]
proposed patch

r=me

Is there an efficient way to make this assertion in release builds too, like we do for some WebKit APIs?
Comment 3 Alexey Proskuryakov 2009-09-11 14:38:16 PDT
Committed revision 48315.

> Is there an efficient way to make this assertion in release builds too, like we
> do for some WebKit APIs?

It's hard for me to estimate - how do we measure JSC API overhead?