WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
29207
Add checks for using WebCore JS context on secondary threads
https://bugs.webkit.org/show_bug.cgi?id=29207
Summary
Add checks for using WebCore JS context on secondary threads
Alexey Proskuryakov
Reported
2009-09-11 13:33:13 PDT
WebCore JavaScript context can never be used on secondary threads, because any such use can cause GC to happen, and thus a lot of DOM code to run on this thread. We need some assertions to more easily catch such conditions with debug builds.
Attachments
proposed patch
(3.54 KB, patch)
2009-09-11 13:36 PDT
,
Alexey Proskuryakov
ggaren
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1
2009-09-11 13:36:51 PDT
Created
attachment 39473
[details]
proposed patch
Geoffrey Garen
Comment 2
2009-09-11 14:01:50 PDT
Comment on
attachment 39473
[details]
proposed patch r=me Is there an efficient way to make this assertion in release builds too, like we do for some WebKit APIs?
Alexey Proskuryakov
Comment 3
2009-09-11 14:38:16 PDT
Committed revision 48315.
> Is there an efficient way to make this assertion in release builds too, like we > do for some WebKit APIs?
It's hard for me to estimate - how do we measure JSC API overhead?
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug