Bug 29196 - wx port is missing several filesystem functions in FileSystemWx.cpp
Summary: wx port is missing several filesystem functions in FileSystemWx.cpp
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit wx (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Kevin Ollivier
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-11 11:32 PDT by Kevin Watters
Modified: 2015-05-07 16:34 PDT (History)
2 users (show)

See Also:


Attachments
implements a few FileSystemWx.cpp functions (2.74 KB, patch)
2009-09-11 11:33 PDT, Kevin Watters
kevino: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Watters 2009-09-11 11:32:52 PDT
The wx port is missing a few FileSystemWx.cpp functions, which are prohibiting HTML5 local databases from being created and managed correctly.
Comment 1 Kevin Watters 2009-09-11 11:33:54 PDT
Created attachment 39454 [details]
implements a few FileSystemWx.cpp functions
Comment 2 Eric Seidel (no email) 2009-09-11 16:48:18 PDT
Comment on attachment 39454 [details]
implements a few FileSystemWx.cpp functions

This looks fine.  Except do you really want to use 0777?
 76     return wxFileName::Mkdir(path, 0777, wxPATH_MKDIR_FULL);

Wouldn't you want to respect the user's umask?  Or at least restrict these to rwx for the user?
Comment 3 Kevin Ollivier 2009-09-13 17:56:05 PDT
Landed in r48344, thanks!(In reply to comment #2)
> (From update of attachment 39454 [details])
> This looks fine.  Except do you really want to use 0777?
>  76     return wxFileName::Mkdir(path, 0777, wxPATH_MKDIR_FULL);
> 
> Wouldn't you want to respect the user's umask?  Or at least restrict these to
> rwx for the user?

Sorry, didn't notice this comment somehow before landing the change. (r48344, BTW) After checking into it, I do see that the POSIX and GTK implementations do set umask to rwx for the user. Whether this is the right behavior for this API or not (vs. respecting the user's umask), I don't know, but it would seem that we run less risk of having unpredictable behavior by doing the same thing as other platforms. I'll leave this ticket open and work up a patch to change it if Kevin W. doesn't beat me to it. ;)

Thanks for catching this!
Comment 4 Eric Seidel (no email) 2009-09-18 13:25:35 PDT
Comment on attachment 39454 [details]
implements a few FileSystemWx.cpp functions

Clearing r+ on this landed change.

It would be better to file a new bug to track the new change.