RESOLVED FIXED Bug 29195
Web Inspector Console should have scope bars 
https://bugs.webkit.org/show_bug.cgi?id=29195
Summary Web Inspector Console should have scope bars
Brian Weinstein
Reported 2009-09-11 11:18:17 PDT
The Web Inspector Console should have scope bars.
Attachments
Console Scope Bars (7.59 KB, patch)
2009-09-11 11:19 PDT, Brian Weinstein 		timothy: review+
bweinstein: commit-queue-
DetailsFormatted DiffDiff
Screen Shot (384.26 KB, image/png)
2009-09-11 11:35 PDT, Brian Weinstein 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Brian Weinstein
Comment 1 2009-09-11 11:19:02 PDT
Created attachment 39452 [details] Console Scope Bars
Anthony Ricaud
Comment 2 2009-09-11 11:27:40 PDT
The console has a small vertical space, especially when the inspector is docked. Adding a scope bar reduces this space even more. Is there another way to add this functionality ? Maybe the horizontal space could be exploited.
Brian Weinstein
Comment 3 2009-09-11 11:34:54 PDT
This goes along the bottom bar, next to the "Clear Console" button, so it doesn't take up any extra vertical space. I'm attaching a screen shot after I write this comment.
Brian Weinstein
Comment 4 2009-09-11 11:35:52 PDT
Created attachment 39455 [details] Screen Shot With errors and warnings selected.
Anthony Ricaud
Comment 5 2009-09-11 11:49:16 PDT
Of course, the bottom bar. Disregard my previous comment.
Timothy Hatcher
Comment 6 2009-09-11 12:02:26 PDT
Comment on attachment 39452 [details] Console Scope Bars > + var createFilterElement = function (category) { This is better written as: function createFilterElement(category) { > + }; Thers is a stray indent space before the "}" brace. No need for the semicolon. > + display: list-item; This should be display: block; Looks good, if you fix these three things.
Brian Weinstein
Comment 7 2009-09-11 13:46:47 PDT
Committed in http://trac.webkit.org/changeset/48314
Note You need to log in before you can comment on or make changes to this bug.