Bug 29195 - Web Inspector Console should have scope bars
Summary: Web Inspector Console should have scope bars
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brian Weinstein
Depends on:
Blocks: 14353
  Show dependency treegraph
Reported: 2009-09-11 11:18 PDT by Brian Weinstein
Modified: 2009-09-11 13:46 PDT (History)
2 users (show)

See Also:

Console Scope Bars (7.59 KB, patch)
2009-09-11 11:19 PDT, Brian Weinstein
timothy: review+
bweinstein: commit-queue-
Details | Formatted Diff | Diff
Screen Shot (384.26 KB, image/png)
2009-09-11 11:35 PDT, Brian Weinstein
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Weinstein 2009-09-11 11:18:17 PDT
The Web Inspector Console should have scope bars.
Comment 1 Brian Weinstein 2009-09-11 11:19:02 PDT
Created attachment 39452 [details]
Console Scope Bars
Comment 2 Anthony Ricaud 2009-09-11 11:27:40 PDT
The console has a small vertical space, especially when the inspector is docked. Adding a scope bar reduces this space even more. Is there another way to add this functionality ? Maybe the horizontal space could be exploited.
Comment 3 Brian Weinstein 2009-09-11 11:34:54 PDT
This goes along the bottom bar, next to the "Clear Console" button, so it doesn't take up any extra vertical space. I'm attaching a screen shot after I write this comment.
Comment 4 Brian Weinstein 2009-09-11 11:35:52 PDT
Created attachment 39455 [details]
Screen Shot

With errors and warnings selected.
Comment 5 Anthony Ricaud 2009-09-11 11:49:16 PDT
Of course, the bottom bar. Disregard my previous comment.
Comment 6 Timothy Hatcher 2009-09-11 12:02:26 PDT
Comment on attachment 39452 [details]
Console Scope Bars

> +    var createFilterElement = function (category) {

This is better written as:

function createFilterElement(category)

> +     };

Thers is a stray indent space before the "}" brace. No need for the semicolon.

> +    display: list-item;

This should be display: block;

Looks good, if you fix these three things.
Comment 7 Brian Weinstein 2009-09-11 13:46:47 PDT
Committed in http://trac.webkit.org/changeset/48314