Bug 29192 - Allow WebKit clients to opt out of high resolution timers on Windows
Summary: Allow WebKit clients to opt out of high resolution timers on Windows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows Vista
: P2 Normal
Assignee: Steve Falkenburg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-11 10:21 PDT by Steve Falkenburg
Modified: 2023-12-03 11:48 PST (History)
0 users

See Also:


Attachments
Add code to disable high-res timers conditionally (10.62 KB, patch)
2009-09-11 10:28 PDT, Steve Falkenburg
darin: review+
Details | Formatted Diff | Diff
Fix bug with preferences to settings propagation (1.71 KB, patch)
2009-09-11 16:44 PDT, Steve Falkenburg
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Falkenburg 2009-09-11 10:21:37 PDT
Gives WebKit embedders an option to opt out of high resolution timers.
Default is that high resolution timers are enabled.
If high res timers are disabled, all timers are fired via WM_TIMER.
Also disables timeBeginPeriod/timeEndPeriod if high resolution timers are disabled.
Comment 1 Steve Falkenburg 2009-09-11 10:28:40 PDT
Created attachment 39448 [details]
Add code to disable high-res timers conditionally
Comment 2 Darin Adler 2009-09-11 10:57:27 PDT
Comment on attachment 39448 [details]
Add code to disable high-res timers conditionally

I'm not sure PLATFORM(WIN) is the right ifdef.

I think it's strange that we're naming the static data members with a "gX" naming scheme. This is not consistent with "m_".
Comment 3 Steve Falkenburg 2009-09-11 11:02:20 PDT
I'm not sure PLATFORM(WIN) fully represents this either, but this seems OK for now. I'd rather conditionalize it for now to the only platform where this is supported.

The "g" naming matches the other static member in Settings. I agree it is a bit odd, and wonder about the utility of even putting this in a static data member vs. a static in the cpp file.
Comment 4 Steve Falkenburg 2009-09-11 11:05:13 PDT
r48308
Comment 5 Steve Falkenburg 2009-09-11 16:44:04 PDT
Created attachment 39491 [details]
Fix bug with preferences to settings propagation