RESOLVED FIXED291917
Element::updateEffectiveTextDirectionIfNeeded recurses children multiple times 
https://bugs.webkit.org/show_bug.cgi?id=291917
Summary Element::updateEffectiveTextDirectionIfNeeded recurses children multiple times
Matt Woodrow
Reported 2025-04-22 16:08:22 PDT
updateEffectiveTextDirectionIfNeeded gets called (only) from insertedIntoAncestor, and does a full descendant walk to compute the direction if children are present. insertedIntoAncestor should already be called for all descendants, so we shouldn't need to recurse both times.
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2025-04-22 16:08:32 PDT
<rdar://problem/149808238>
Matt Woodrow
Comment 2 2025-04-22 16:10:54 PDT
Pull request: https://github.com/WebKit/WebKit/pull/44389
EWS
Comment 3 2025-04-23 19:41:36 PDT
Committed 294037@main (e31e3a25e7d4): <https://commits.webkit.org/294037@main> Reviewed commits have been landed. Closing PR #44389 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.